Add a simple finagle/grpc benchmark#1247
Merged
xerial merged 3 commits intowvlet:masterfrom Aug 19, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1247 +/- ##
=======================================
Coverage 83.30% 83.31%
=======================================
Files 296 296
Lines 11414 11415 +1
Branches 715 725 +10
=======================================
+ Hits 9509 9510 +1
Misses 1905 1905
Continue to review full report at Codecov.
|
This was referenced Aug 19, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a simple benchmark to see the performance of gRPC compared to Finagle:
Generally, gRPC seems 1.5 ~ 2x faster than Finagle.
Updates
Added async RPC call results as well:
gRPC is super fast: 35,829 rpc/sec: 5x faster than sync client and 3x faster than finagle-async client!