airframe-http: #399 Add a standard JSON request logger#1073
Merged
xerial merged 13 commits intowvlet:masterfrom May 13, 2020
Merged
airframe-http: #399 Add a standard JSON request logger#1073xerial merged 13 commits intowvlet:masterfrom
xerial merged 13 commits intowvlet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
- Coverage 82.40% 82.31% -0.09%
==========================================
Files 268 270 +2
Lines 10148 10258 +110
Branches 651 670 +19
==========================================
+ Hits 8362 8444 +82
- Misses 1786 1814 +28
Continue to review full report at Codecov.
|
xerial
commented
May 12, 2020
| libraryDependencies += "org.wvlet.airframe" %% "airframe-http-finagle" % (version) | ||
| ``` | ||
|
|
||
| ## Defining HTTP Endpoints |
Member
Author
There was a problem hiding this comment.
This doc has moved to docs/airframe-http.md
takezoe
reviewed
May 13, 2020
takezoe
reviewed
May 13, 2020
takezoe
reviewed
May 13, 2020
Member
Author
|
CI is failing because of some GitHub Action issue. |
shimamoto
approved these changes
May 13, 2020
| m += "remote_host" -> request.remoteAddress.getHostAddress | ||
| m += "remote_port" -> request.remotePort | ||
|
|
||
| m.result |
Collaborator
There was a problem hiding this comment.
It might be nice to have user_agent. Just a thought
Member
Author
There was a problem hiding this comment.
Yes. user_agent can be read from HTTP headers, so it's already recorded.
Member
Author
There was a problem hiding this comment.
takezoe
approved these changes
May 13, 2020
Member
takezoe
left a comment
takezoe
left a comment
There was a problem hiding this comment.
Thanks for adding HttpErrorLogger!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a standard http request/response logger so that airframe-http applications always have proper logging.
This will close #399