Stop mutating the string returned by Symbol#to_s #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvanbergen
approved these changes
Sep 26, 2019
rafaelfranca
approved these changes
Sep 26, 2019
Collaborator
rafaelfranca
left a comment
rafaelfranca
left a comment
There was a problem hiding this comment.
CI is very broken 😂
Collaborator
Author
|
Yeah, I'll do on pass on it. @wvanbergen can I haz push access? |
casperisfine
force-pushed
the
frozen-symbol-to_s
branch
from
2ac69fe to
63de1e2
Compare
Collaborator
Author
|
🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MRI is currently experimenting with returning a frozen string in
Symbol#to_s, see ruby/ruby#2437Unless that experimental feature end up reverted, this gem need to be updated.
@wvanbergen @rafaelfranca