Skip to content

Commit 898f880

Browse files
psmarshallCommit Bot
authored andcommitted
[cpu-profiler] Turn on detailed line info for optimized code
Cautiously turn on this flag by default to check the impact on performance bots. Could show minor regressions in old space and/or code_and_metadata memory buckets. Bug: v8:7983 Change-Id: Ic4369cdb0231f4f88eada699da948e8bb48a25fd Reviewed-on: https://chromium-review.googlesource.com/1162234 Commit-Queue: Yang Guo <[email protected]> Reviewed-by: Yang Guo <[email protected]> Cr-Commit-Position: refs/heads/master@{#54908}
1 parent d7ca375 commit 898f880

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

src/flag-definitions.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1253,9 +1253,8 @@ DEFINE_BOOL(log_function_events, false,
12531253
DEFINE_BOOL(prof, false,
12541254
"Log statistical profiling information (implies --log-code).")
12551255

1256-
DEFINE_BOOL(detailed_line_info, false,
1256+
DEFINE_BOOL(detailed_line_info, true,
12571257
"Always generate detailed line information for CPU profiling.")
1258-
DEFINE_IMPLICATION(future, detailed_line_info)
12591258

12601259
#if defined(ANDROID)
12611260
// Phones and tablets have processors that are much slower than desktop

0 commit comments

Comments
 (0)