Render JSON error when it occurs on a request path ending with .json#780
Merged
Render JSON error when it occurs on a request path ending with .json#780
Conversation
While ACCEPT header might not be passed in these requests, paths ending with .json are likely to expect a JSON response, so when an error occurs, respond with a JSON error. This fixes error modal in such requests and displays an informative message now instead of empty content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While ACCEPT header might not be passed in these requests, paths ending with .json are likely to expect a JSON response, so when an error occurs, respond with a JSON error.
This fixes error modal in such requests and displays an informative message now instead of empty content.