Skip to content

Comments

Update JS deps#767

Merged
tadast merged 11 commits intowurmlab:masterfrom
joko3ono:tt/update-js-deps
Jul 23, 2024
Merged

Update JS deps#767
tadast merged 11 commits intowurmlab:masterfrom
joko3ono:tt/update-js-deps

Conversation

@joko3ono
Copy link
Contributor

@joko3ono joko3ono commented Jul 13, 2024

What does this PR contain?

  • Fix: jest error
  • Fix: After search page, the loading page halted
Screenshot 2024-07-15 at 01 56 19

@joko3ono joko3ono changed the base branch from tt/update-js-deps to master July 13, 2024 22:50
@joko3ono joko3ono marked this pull request as ready for review July 13, 2024 22:51
@joko3ono joko3ono marked this pull request as draft July 13, 2024 22:51
@joko3ono joko3ono changed the base branch from master to tt/update-js-deps July 13, 2024 22:54
@tadast tadast changed the base branch from tt/update-js-deps to master July 15, 2024 09:03
@joko3ono joko3ono requested a review from tadast July 20, 2024 23:44
@joko3ono joko3ono force-pushed the tt/update-js-deps branch from bc19b96 to eda4320 Compare July 20, 2024 23:57
@joko3ono joko3ono marked this pull request as ready for review July 20, 2024 23:57
@joko3ono joko3ono changed the title [WIP] Update JS deps Update JS deps Jul 21, 2024

expect(getByText(/Network response was not ok/i)).toBeTruthy();
});
});
Copy link
Collaborator

@tadast tadast Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@tadast tadast mentioned this pull request Jul 22, 2024
@joko3ono joko3ono force-pushed the tt/update-js-deps branch from eda4320 to 92b5b49 Compare July 22, 2024 22:33
@joko3ono joko3ono requested a review from tadast July 23, 2024 00:16
tadast added 2 commits July 23, 2024 09:50
Do not try to parse response body if it's empty
Instead of an arbitrary timeout of 200ms, request the next paint frame
so that we call the function as soon as react paints the DOM
@tadast tadast force-pushed the tt/update-js-deps branch from ee0330c to a0c360e Compare July 23, 2024 09:01
@tadast tadast merged commit e67e150 into wurmlab:master Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants