Fix advanced arguments help modal#728
Merged
yannickwurm merged 3 commits intowurmlab:masterfrom Feb 21, 2024
Merged
Conversation
This file should not diff after running bundle install, so perhaps someone forgot to commit it.
This reverts commit ecfaa3c. The change had an unintended consequence of disabling the help modal for advanced features. I'd argue that wurmlab#695 is a bit misleading - it is expected for HTML labels to be clickable. Clicking on an input field label should focus the input field, which it was doing. I don't think this should change. It just happens that the help modal trigger is crammed into the label too, so it can perhaps get confusing when the two elements next to each other are clickable and react to the same hover - perhaps the latter needs to change instead?
Upgrading Sinatra has broken HTTP status codes for some errors. There was a Sinatra change sinatra/sinatra#1519 in V3 (SequenceServer has gone from v2 -> V4 recently) that made the http status code setting from the exception class more explicit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ecfaa3c.
The change had an unintended consequence of disabling the help
modal for advanced features.
I'd argue that #695
is a bit misleading - it is expected for HTML
labels to be clickable. Clicking on an input field label should
focus the input field, which it was doing. I don't think this should change.
It just happens that the help modal trigger is crammed into the label
too, so it can perhaps get confusing when the two elements next to each other are clickable and react to the same hover - perhaps the latter needs to change instead? Maybe the trigger icon can move to be inset on the right side of the input field?