Closed
Conversation
On branch test-cases-grg Changes to be committed: modified: .github/workflows/tests.yml modified: package-lock.json modified: package.json
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg
modified: .github/workflows/tests.yml
We can probably do away with the --debug option for CodeClimate now.
modified: jest.config.js
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml modified: Gemfile.lock
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
…m to be running. On branch test-cases-grg modified: .github/workflows/tests.yml
On branch test-cases-grg Changes to be committed: modified: .github/workflows/tests.yml modified: package-lock.json modified: package.json
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg
modified: .github/workflows/tests.yml
We can probably do away with the --debug option for CodeClimate now.
modified: jest.config.js
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml modified: Gemfile.lock
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
On branch actions-grg modified: .github/workflows/tests.yml
…m to be running. On branch test-cases-grg modified: .github/workflows/tests.yml
…to test-cases-grg
On branch test-cases-grg modified: .github/workflows/tests.yml
On branch test-cases-grg modified: spec/blast_versions/blast_2.9.0/import_spec_capybara_local_2.9.0.rb
On branch test-cases-grg modified: .github/workflows/tests.yml
On branch test-cases-grg modified: spec/blast_versions/blast_2.9.0/import_spec_capybara_local_2.9.0.rb
On branch test-cases-grg modified: .github/workflows/tests.yml
On branch test-cases-grg modified: .github/workflows/tests.yml
On branch test-cases-grg modified: .github/workflows/tests.yml
tadast
added a commit
to tadast/sequenceserver
that referenced
this pull request
Mar 5, 2024
Thanks wurmlab#689 by @augeas
Merged
tadast
added a commit
to tadast/sequenceserver
that referenced
this pull request
Mar 6, 2024
Thanks wurmlab#689 by @augeas
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This updates the "tests" workflow to merge the coverage report from the new js tests with the rspec coverage and sends both to CodeClimate, also attaching both to the action annotations.
The Jest configuration, as supplied, was including several spurious files in the coverage reports, e.g:
Users/priyam/sequenceserver/node_modules/biojs-vis-sequence/node_modules/biojs-events
Although the value of collectCoverageFrom in jest.config.js looks entirely reasonable, removing it and reverting to defaults seems to have resolved the issue.
The additions to the workflow can be seen running successfully on the actions-grg branch