Skip to content

Test cases grg#689

Closed
augeas wants to merge 46 commits intomasterfrom
test-cases-grg
Closed

Test cases grg#689
augeas wants to merge 46 commits intomasterfrom
test-cases-grg

Conversation

@augeas
Copy link
Contributor

@augeas augeas commented Oct 5, 2023

This updates the "tests" workflow to merge the coverage report from the new js tests with the rspec coverage and sends both to CodeClimate, also attaching both to the action annotations.

The Jest configuration, as supplied, was including several spurious files in the coverage reports, e.g:

Users/priyam/sequenceserver/node_modules/biojs-vis-sequence/node_modules/biojs-events

Although the value of collectCoverageFrom in jest.config.js looks entirely reasonable, removing it and reverting to defaults seems to have resolved the issue.

The additions to the workflow can be seen running successfully on the actions-grg branch

augeas added 30 commits July 21, 2023 10:32
 On branch test-cases-grg
 Changes to be committed:
	modified:   .github/workflows/tests.yml
	modified:   package-lock.json
	modified:   package.json
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
           We can probably do away with the --debug option for CodeClimate now.
	modified:   jest.config.js
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
	modified:   Gemfile.lock
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
…m to be running.

 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
 On branch test-cases-grg
 Changes to be committed:
	modified:   .github/workflows/tests.yml
	modified:   package-lock.json
	modified:   package.json
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
           We can probably do away with the --debug option for CodeClimate now.
	modified:   jest.config.js
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
	modified:   Gemfile.lock
 On branch actions-grg
	modified:   .github/workflows/tests.yml
augeas and others added 11 commits August 9, 2023 15:01
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
…m to be running.

 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
On branch test-cases-grg
	modified:   spec/blast_versions/blast_2.9.0/import_spec_capybara_local_2.9.0.rb
 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
 On branch test-cases-grg
	modified:   spec/blast_versions/blast_2.9.0/import_spec_capybara_local_2.9.0.rb
 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link

ghost commented Oct 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

tadast added a commit to tadast/sequenceserver that referenced this pull request Mar 5, 2024
@tadast tadast mentioned this pull request Mar 5, 2024
tadast added a commit to tadast/sequenceserver that referenced this pull request Mar 6, 2024
@yannickwurm
Copy link
Member

yannickwurm commented Mar 8, 2024

Super huge thanks @augeas -this was merged into #732

@yannickwurm yannickwurm closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants