Add .faa as a recognised fasta extension#684
Merged
yannickwurm merged 3 commits intowurmlab:masterfrom Oct 3, 2023
Merged
Conversation
It was missing from the list (its nucleotide complement .fna is in here). Also order the list alphabetically.
Did a regex replace of some execute_script instance with native capybara selectors that will wait for these elements to render on the page before proceeding
tadast
commented
Oct 2, 2023
| # download to finish. | ||
|
|
||
| page.execute_script("$('.download-aln:eq(1)').click()") | ||
| expect(page).to have_selector('.download-aln', minimum: 30) # Wait for react to render all alignments |
Collaborator
Author
There was a problem hiding this comment.
FYI: lower in the spec it tries to tick some checkboxes lower on the page and sometimes the test is faster than the react renderer, so adding this clause makes capybara wait until at least the first 30 alignments are rendered, ensuring checkbox selection will not fail
tadast
force-pushed
the
tt/faa
branch
6 times, most recently
from
d81b8c8 to
0964017
Compare
Tests were failing on the CI, because spec/dotdir is committed, but gitignored, therefore locally I had xml and tsv files after running the test suite, but on the CI they were not present, so the issue was invisible.
Member
|
Thank you @tadast - this is great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was missing from the list (its nucleotide counterpart
.fnais in here already).Also order the list alphabetically.