Skip to content

Comments

Fix thread shutdown logic#681

Merged
yannickwurm merged 1 commit intowurmlab:masterfrom
tadast:tt/typo
Sep 18, 2023
Merged

Fix thread shutdown logic#681
yannickwurm merged 1 commit intowurmlab:masterfrom
tadast:tt/typo

Conversation

@tadast
Copy link
Collaborator

@tadast tadast commented Sep 18, 2023

Shutdown was calling a non-existant 'schedule' method. Seems like the original thread pool's schedule method was renamed to 'queue' here, but this reference was not updated.

Shutdown was calling a non-existant 'schedule' method. Seems like
the original thread pool's schedule method was renamed to 'queue'
here, but this reference was not updated.
@ghost
Copy link

ghost commented Sep 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@yannickwurm yannickwurm merged commit 462be12 into wurmlab:master Sep 18, 2023
@yannickwurm
Copy link
Member

Great catch - thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants