add method for computing number of sequences in a query#679
Merged
yannickwurm merged 4 commits intowurmlab:masterfrom Feb 21, 2024
Merged
add method for computing number of sequences in a query#679yannickwurm merged 4 commits intowurmlab:masterfrom
yannickwurm merged 4 commits intowurmlab:masterfrom
Conversation
tadast
reviewed
Sep 11, 2023
Collaborator
tadast
left a comment
tadast
left a comment
There was a problem hiding this comment.
Variable name could be improved, but the code looks good to me 👍
| # The following params are for analytics only | ||
| @num_threads = config[:num_threads] | ||
| @query_length = calculate_query_size | ||
| @number_of_sequences = calculate_number_of_sequences |
Collaborator
There was a problem hiding this comment.
I think it would be more self explanatory if it was called number_of_query_sequences or sequences_in_query, what do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses issue #669