Skip to content

Comments

Test cases grg#676

Closed
augeas wants to merge 41 commits intomasterfrom
test-cases-grg
Closed

Test cases grg#676
augeas wants to merge 41 commits intomasterfrom
test-cases-grg

Conversation

@augeas
Copy link
Contributor

@augeas augeas commented Aug 4, 2023

This updates the "tests" workflow to merge the coverage report from the new js tests with the rspec coverage and sends both to CodeClimate, also attaching both to the action annotations.

The Jest configuration, as supplied, was including several spurious files in the coverage reports, e.g:

Users/priyam/sequenceserver/node_modules/biojs-vis-sequence/node_modules/biojs-events

(See previous executions of the action. )

Although the value of collectCoverageFrom in jest.config.js looks entirely reasonable, removing it and reverting to defaults seems to have resolved the issue.

The additions to the workflow can be seen running successfully on the actions-grg branch.

augeas added 18 commits July 21, 2023 10:32
 On branch test-cases-grg
 Changes to be committed:
	modified:   .github/workflows/tests.yml
	modified:   package-lock.json
	modified:   package.json
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
           We can probably do away with the --debug option for CodeClimate now.
	modified:   jest.config.js
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
	modified:   Gemfile.lock
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
…m to be running.

 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
@augeas augeas requested a review from yannickwurm August 4, 2023 15:05
@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

@augeas augeas mentioned this pull request Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

augeas added 7 commits August 9, 2023 15:01
 On branch test-cases-grg
 Changes to be committed:
	modified:   .github/workflows/tests.yml
	modified:   package-lock.json
	modified:   package.json
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
           We can probably do away with the --debug option for CodeClimate now.
	modified:   jest.config.js
augeas added 8 commits August 9, 2023 15:01
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
	modified:   Gemfile.lock
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
 On branch actions-grg
	modified:   .github/workflows/tests.yml
…m to be running.

 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11053 lines exceeds the maximum allowed for the inline comments feature.

On branch test-cases-grg
	modified:   spec/blast_versions/blast_2.9.0/import_spec_capybara_local_2.9.0.rb
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11061 lines exceeds the maximum allowed for the inline comments feature.

 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
@augeas
Copy link
Contributor Author

augeas commented Aug 10, 2023

Killed off some of the page.executes that were using jQuery in the rspec tests, this reduces but doesn't entirely eliminate the random test failures.

augeas and others added 4 commits August 11, 2023 16:01
 On branch test-cases-grg
	modified:   spec/blast_versions/blast_2.9.0/import_spec_capybara_local_2.9.0.rb
 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
 On branch test-cases-grg
	modified:   .github/workflows/tests.yml
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 0707c4d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 26.4% (-55.5% change).

View more on Code Climate.

@augeas augeas closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants