Use full image for builder stage; update to bullseye#675
Merged
yannickwurm merged 1 commit intowurmlab:masterfrom Aug 9, 2023
nathanweeks:issue-673
Merged
Use full image for builder stage; update to bullseye#675yannickwurm merged 1 commit intowurmlab:masterfrom nathanweeks:issue-673
yannickwurm merged 1 commit intowurmlab:masterfrom
nathanweeks:issue-673
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address issue #673 by using a full (rather than slim) image for the builder stage. An alternative would be adding
g++to the list of installed packages:sequenceserver/Dockerfile
Lines 13 to 15 in ae07659
However, using the full base image (which contains Debian packages needed to build ruby extensions, obviating the need to explicitly install such packages via the Dockerfile) seems less likely to fail in the future due to missing Debian packages dependencies that extensions may have.
It's also probably worth updating from buster to bullseye, as support for new Docker official ruby buster images was dropped after bookworm was available (it might be preferable to delay updating to bookworm in case any users still run an old Docker < 2.10.10, which has difficulty building images with glibc >= 2.34 due to this issue).