Add stylelint engine for .css linting#532
Merged
yeban merged 2 commits intowurmlab:masterfrom Jun 21, 2021
Merged
Conversation
|
Code Climate has analyzed commit 4c2ea2f and detected 0 issues on this pull request. View more on Code Climate. |
Contributor
|
Thanks! |
yeban
added a commit
that referenced
this pull request
Jun 25, 2021
Signed-off-by: Anurag Priyam <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues with CSSLint
Running CSSLint via codeclimate has several issues:
--ignore="rule1","rule2").csslint --format=compact public/css/ | sed 's/line/\n\nline/g'to get a useful output. The standalonecsslintdoes at least adhere to .csslintrc.All in all, I'm not sure the codeclimate csslint plugin is that useful as a CI tool. Though you may still want to use it to find the * and *= issues (though even this is disputed).
stylelint
Stylelint doesn't pick up all of the same issues as CSSLint but
--fixoption to automatically fix some issues.codeclimate -e, stylelint does print the name of the broken rule(s).