Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes replication functionality to support both HTML and JSON response formats from AEM replication endpoints. The changes implement a unified response handling approach by introducing a common interface and adapting existing code to handle different content types.
- Introduces a ResponseData interface to standardize response handling across different formats
- Adds JSON response parsing capability to complement existing HTML response handling
- Updates replication logic to automatically detect and handle both JSON and HTML responses based on content type
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/sling/response.go | Defines common ResponseData interface for unified response handling |
| pkg/sling/json_response.go | Implements JSON response parsing with ResponseData interface |
| pkg/sling/html_response.go | Adds GetMessage method to HTMLData to implement ResponseData interface |
| pkg/repl.go | Updates replication logic to auto-detect and handle both JSON and HTML responses |
| .vscode/launch.json | Adds VS Code debug configurations for development |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #286