Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds offline mode support for OakRun by allowing users to specify a pre-installed local JAR file path instead of downloading it automatically. This enhances the tool's flexibility for environments with restricted internet access or when users prefer to manage JAR files locally.
Key changes:
- Added
jar_fileconfiguration option to all AEM configuration templates - Improved logging messages for clarity and consistency
- Minor code formatting cleanup
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/project/instance/aem/default/etc/aem.yml | Added jar_file configuration option with documentation |
| pkg/project/app_cloud/aem/default/etc/aem.yml | Added jar_file configuration option with documentation |
| pkg/project/app_classic/aem/default/etc/aem.yml | Added jar_file configuration option with documentation |
| pkg/oak_run.go | Improved logging messages and minor formatting cleanup |
| examples/docker/src/aem/default/etc/aem.yml | Added jar_file configuration option with documentation |
| .goreleaser.yaml | Added GitHub changelog configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if or.JarFile != "" { | ||
| // No preparation needed if using a local JAR | ||
| log.Infof("using Oak Run JAR from local file '%s'", or.JarFile) | ||
| log.Debugf("using OakRun from JAR file '%s'", or.JarFile) |
There was a problem hiding this comment.
The log message uses 'OakRun' but should be consistent with 'Oak Run' (with space) as used elsewhere in the codebase for better consistency.
| log.Debugf("using OakRun from JAR file '%s'", or.JarFile) | |
| log.Debugf("using Oak Run from JAR file '%s'", or.JarFile) |
| version_template: "{{ incpatch .Version }}-next" | ||
|
|
||
| changelog: | ||
| use: github |
There was a problem hiding this comment.
[nitpick] This changelog configuration change appears unrelated to the OakRun offline functionality described in the PR title. Consider moving this change to a separate PR for better commit organization.
fixes #315