Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces configurable OS selection for the AEM SDK dispatcher distribution unpacking process. Instead of relying solely on runtime OS detection, users can now explicitly specify which OS version of the dispatcher tools to use through configuration.
- Adds OS type constants and validation in a new SDK constants module
- Implements configurable OS selection with "auto", "unix", and "windows" options
- Updates default configuration files to include the new SDK OS setting with "auto" as default
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/sdk/constants.go | Defines OS type constants and helper function for validation |
| pkg/sdk.go | Adds OS field to SDK struct and implements configurable OS determination logic |
| pkg/cfg/defaults.go | Sets default SDK OS configuration value |
| pkg/project/*/aem.yml | Updates configuration templates with new SDK OS setting |
| examples/docker/*/aem.yml | Updates example configuration with new SDK OS setting |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.