closes #315: Allow downloadURL to reference local file for oak-run ja…#316
Merged
krystian-panek-vmltech merged 4 commits intowttech:mainfrom Aug 28, 2025
Merged
Conversation
pkg/oak_run.go
Outdated
| log.Infof("downloading Oak Run JAR from URL '%s' to file '%s'", or.DownloadURL, jarFile) | ||
| if err := httpx.DownloadOnce(or.DownloadURL, jarFile); err != nil { | ||
| downloadURL := or.DownloadURL | ||
|
|
Contributor
There was a problem hiding this comment.
hmmm there is similar logic already here
if homeDir is defined then download url and downloading at all is skipped
IMO we should follow this pattern also for oak run; so new prop for preinstalled oak run need to be introduced then
Contributor
Author
There was a problem hiding this comment.
I agree, I adjusted to also not need a copy anymore, local jar file will be used directly
yfrickx-kbc
force-pushed
the
feature/allow-offline-oak-run-jar
branch
from
d961b72 to
134475e
Compare
pkg/oak_run.go
Outdated
| DownloadURL: cv.GetString("vendor.oak_run.download_url"), | ||
| StorePath: cv.GetString("vendor.oak_run.store_path"), | ||
| DownloadURL: cv.GetString("vendor.oak_run.download_url"), | ||
| LocalJar: cv.GetString("vendor.oak_run.local_jar"), |
Contributor
There was a problem hiding this comment.
I prefer just jar_file / JarFile
similar to existing dist_file or license_file in the aem.yml
pkg/oak_run.go
Outdated
| } | ||
| if check.UpToDate { | ||
| log.Debugf("existing OakRun '%s' is up-to-date", or.DownloadURL) | ||
| log.Debugf("existing OakRun (url: '%s', local: '%s') is up-to-date", or.DownloadURL, or.LocalJar) |
Contributor
There was a problem hiding this comment.
I am not sure if logging all details here is needed, just do like in jdk.go
Contributor
|
almost ready, thanks for contributing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.