Restart instance when Java changed#312
Merged
krystian-panek-vmltech merged 1 commit intomainfrom Aug 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds Java home directory tracking to the local instance update lock mechanism to enable instance restarts when the Java installation changes.
- Adds
JavaHomefield to the update lock structure to track Java installation path - Retrieves and stores the current Java home directory when creating update locks
Comments suppressed due to low confidence (1)
pkg/local_instance.go:536
- [nitpick] The variable name 'javaHomeDir' is inconsistent with the struct field name 'JavaHome'. Consider renaming to 'javaHome' for consistency.
javaHomeDir, err := li.JavaManager().FindHomeDir()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.