Skip to content

Settings are not always restored when restore settings is called #390

@Utumno

Description

@Utumno

You could change this to "never restored". The main issue is that that basher.BashFrame#Restart calls Close which triggers basher.BashFrame#OnCloseWindow which calls basher.BashFrame#SaveSettings which saves current settings overwriting the just restored ones. Fantastic. It's called "event programming"

But I don't want this monkey patched - Restart uses appRestart and uacRestart globals (yak) and does some mumbo jumbo isinstance whatever - then the globals are used in bash.exit_cleanup. We should directly edit the sys.argv (probably inside Restart) and eliminate most of this code - breakpoints needed.

And of course skip saving settings when we restore them, duh!

@D4id4los - do you think you could take this up ? It's related to Bash boot work you're working on

EDIT: restore settings itself is tricky (may restore bash.ini which changes paths etc - so testing needed anyway - plus settings refactoring is a blocker for other stuff like profile - see #178)

Metadata

Metadata

Labels

A-bootArea: Early Boot (bash.py, bush.py and initialization.py)A-settingsArea: Settings (very WIP, all over the place - basher and bass)C-bugCategory: Bug, an acknowledged defect in the programM-relnotesMisc: Issue should be listed in the version history for its milestone

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions