Skip to content

Better handling of missing game ini #290

@Utumno

Description

@Utumno

See discussion starting here: http://forums.bethsoft.com/topic/1589330-wrye-bash-thread-107/page-7#entry25089222

Bottom line - warn and add a menu item for creating the missing ini. Plus, fix refresh UI when ini is created.

Oblivion.ini refresh glitch: when Oblivion ini does not exist and is
created tweaks do not change their status from invalid...
When ini is created by Bash - due to getStatus not realizing it changed

Ok:

  • do not create the ini without warning the user (806cf93)

  • menu item for creating the game ini some other spring

  • use ask_create_game_ini in warn_game_ini

  • rework the saves profile code for when the ini does not exist

  • rework refresh to detect the created game.ini

  • Create oblivion ini on applying an ini tweak (I canceled)

    Traceback (most recent call last):
    File "bash\balt.py", line 1673, in OnItemSelected
      self._select(modName)
    File "bash\basher\__init__.py", line 659, in _select
      def _select(self, tweakfile): self.panel.SelectTweak(tweakfile)
    File "bash\basher\__init__.py", line 1559, in SelectTweak
      self.tweakContents.RefreshTweakLineCtrl(tweakFile)
    File "bash\basher\__init__.py", line 697, in RefreshTweakLineCtrl
      self.iniContents.SetItemBackgroundColour(lineNo,color)
    File "C:\_\Python27\lib\site-packages\wx-2.8-msw-unicode\wx\_controls.py", line 4801, in SetItemBackgroundColour
      return _controls_.ListCtrl_SetItemBackgroundColour(*args, **kwargs)
    wx._core.PyAssertionError: C++ assertion "id >= 0 && id < GetItemCount()" failed at ..\..\src\msw\listctrl.cpp(771) in wxListCtrl::SetItem(): invalid item index in SetItem
    

Metadata

Metadata

Assignees

Labels

C-enhancementCategory: Enhancement, a request to add or enhance a featureM-relnotesMisc: Issue should be listed in the version history for its milestone

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions