Add FY3C-MWHS2 radiance DA capability by weisunncar · Pull Request #797 · wrf-model/WRF

weisunncar · 2019-02-27T18:21:15Z

TYPE:new feature

KEYWORDS: FY3C-MWHS2, Radiance, RTTOV

SOURCE: Wei Sun (NSSC,CAS/NCAR) and Jake Liu (NCAR)

DESCRIPITION OF CHANGES:

Add new capability to assimilate FY3C-MWHS2 Level-1 data in HDF5 format, which can be downloaded from https://satellite.nsmc.org.cn/portalsite. Assimilation of this observation only works with RTTOV, since CRTM has no coefficients corresponding to FY3C.
MWHS2 has 15 channels (1 at 89 GHz, 8 at 118.75 GHz, 1 at 150 GHz, and 5 at 183 GHz) and 98 FOVs within the swath width 2660 km. Channels 1-9's footprint is 29 km and channels 10-15's footprint is 16 km. See https://www.ecmwf.int/sites/default/files/elibrary/2015/10668-evaluation-fy-3c-mwhs-2-ecmwf.pdf and https://www.wmo-sat.info/oscar/satellites/view/115 for more detail.
Sensor triplet for FY3-C-MWHS2 is (23, 3, 73). Observation file name conversion?

MODIFIED FILES:
M Registry/registry.var
M var/da/da_obs_io/da_read_y_unit.inc
A var/da/da_radiance/da_qc_mwhs2.inc
M var/da/da_radiance/da_qc_rad.inc
M var/da/da_radiance/da_radiance.f90
M var/da/da_radiance/da_radiance1.f90
M var/da/da_radiance/da_radiance_init.inc
A var/da/da_radiance/da_read_obs_hdf5mwhs2.inc
M var/da/da_radiance/da_read_pseudo_rad.inc
M var/da/da_radiance/da_setup_radiance_structures.inc
M var/da/da_radiance/module_radiance.f90
M var/da/da_setup_structures/da_setup_obs_structures.inc
M var/da/da_setup_structures/da_setup_structures.f90
M var/run/VARBC.in
A var/run/radiance_info/fy3-3-mwhs2.info

TEST CONDUCTED:

WRFDA regression tests ran successfully with gnu/ifort+mpt on Cheyenne.
New FY3C-MWHS2 radiance DA capability is tested on Cheyenne for 6-hour cycling DA over a 9km domain with a grid mesh of 600 x 450 x50.

TYPE:new feature KEYWORDS: FY3C-MWHS2, Radiance, RTTOV SOURCE: Wei Sun (NSSC,CAS/NCAR) and Jake Liu (NCAR) DESCRIPITION OF CHANGES: Add new capability to assimilate FY3C-MWHS2 Level-1 data in HDF5 format, which can be downloaded from https://satellite.nsmc.org.cn/portalsite. Assimilation of this observation only works with RTTOV, since CRTM has no coefficients corresponding to FY3C. MODIFIED FILES: modified: Registry/registry.var modified: var/da/da_obs_io/da_read_y_unit.inc new file: var/da/da_radiance/da_qc_mwhs2.inc modified: var/da/da_radiance/da_qc_rad.inc modified: var/da/da_radiance/da_radiance.f90 modified: var/da/da_radiance/da_radiance1.f90 modified: var/da/da_radiance/da_radiance_init.inc new file: var/da/da_radiance/da_read_obs_fy3c.inc modified: var/da/da_radiance/da_read_pseudo_rad.inc modified: var/da/da_radiance/da_setup_radiance_structures.inc modified: var/da/da_radiance/da_write_iv_rad_ascii.inc modified: var/da/da_radiance/da_write_oa_rad_ascii.inc modified: var/da/da_radiance/module_radiance.f90 modified: var/da/da_setup_structures/da_setup_obs_structures.inc modified: var/da/da_setup_structures/da_setup_structures.f90 modified: var/run/VARBC.in new file: var/run/radiance_info/fy3-3-mwhs2.info TEST CONDUCTED: 1. WRFDA regression tests ran successfully with ifort+mpt on Cheyenne. 2. New FY3C-MWHS2 radiance DA capability is tested on Cheyenne for 6-hour cycling DA over a 9km domain with a grid mesh of 600*450*50.

liujake · 2019-02-27T18:29:58Z

@weimmm No need to create another PR. From now on, stop acting on this PR before I tell you what is the correct procedure to do.

jjguerrette

Just a few changes to be made, mostly semantic. Good work Wei.

jjguerrette · 2019-02-27T18:54:42Z

var/da/da_radiance/module_radiance.f90

        & 'smmr    ', 'ahi     ', 'irs     ', 'altika  ', 'iasing  ',  &
-        & 'tm      ', 'fci     ', 'amsr1   ', 'amsr2   ', 'vissr   ',  &
-        & 'slstr   '/)
+        & 'tm      ', 'fci     ', 'amsr    ', 'amsr2   ', 'vissr   ',  &


Why change the name to amsr from amsr1? Also, where did you find the replacement names for the "spare" and "reserved" instruments? The RTTOV v12 Users Guide (March 2018) does not have them. Thanks.

I found the names from the RTTOV code, which is RTTOV/src/main/rttov_const.F90. To make the name consistent with RTTOV, I copy the whole name table from the RTTOV code to the DA file here. Thanks.

jjguerrette · 2019-02-27T19:21:55Z

var/da/da_radiance/da_read_obs_fy3c.inc

+   !  Purpose: read in FY3C MWHS2 Level-1 data in HDF5 format
+   !           and form innovation structure
+   !
+   !   METHOD: use F90 sequantial data structure to avoid read the file twice


Change to " ! METHOD: use F90 sequential data structure to avoid reading the file twice"

The sentence has been changed according to your suggestion. Thanks.

jjguerrette · 2019-02-27T19:26:45Z

var/da/da_radiance/da_read_obs_fy3c.inc

+   real(r_kind)     :: dlon_earth,dlat_earth
+   integer(i_kind)  :: num_amsr2_local, num_amsr2_global, num_amsr2_used, num_amsr2_thinned
+   integer(i_kind)  :: num_amsr2_used_tmp, num_amsr2_file
+   integer(i_kind)  :: num_amsr2_local_local, num_amsr2_global_local, num_amsr2_file_local


Here and throughout, amsr2/AMSR2 needs to be changed to mwhs2/MWHS2.

All the names have been changed according to your suggestion. Thanks.

davegill · 2019-03-04T15:35:05Z

var/da/da_radiance/da_write_iv_rad_ascii.inc

                  write(unit=innov_rad_unit,fmt='(a)') 'RTM_level pres(mb) T(k) Q(ppmv)'
                  do k = 1, nlevelss
-                     write(unit=innov_rad_unit,fmt='(i3,f10.2,f8.2,e11.4)') &
+                     write(unit=innov_rad_unit,fmt='(i3,f10.3,f8.2,e11.4)') &


@weimmm
The modification of f10.2 to f10.3 - is this a bug fix outside the scope of this PR? If this mod is required for this PR, does this change mean that older data is no longer supported?

@davegill
This was just a clearer output for the pressure corresponding to the RTM_level in the oma files. I have changed it back to 'f10.2'. Thanks.

davegill · 2019-03-04T15:42:48Z

@weimmm @liujake @jjguerrette
Folks,
This seems to be put together pretty well. The PR is correctly made to develop. I am not approving this, but I do not see anything that is problematic. There is a small change to the registry for DA, and all other mods are to the DA code specifically. The commit message is clear, and the testing seems appropriate.

liujake · 2019-03-05T03:48:31Z

I will find time to review it. No rush to push it in.

liujake · 2019-03-16T17:34:39Z

@weimmm Can you also run a WRFDA Regtest with gnu+mpt on Cheyenne?

weisunncar · 2019-03-16T17:55:34Z

Dear Dr. Liu, Truly thanks for your suggestion. Actually, I have tried to run the REGTEST with gnu, while the compile failed. The same situation also happened when I started to use WRF+RTTOV to deal with the FY3C at the beginning, it could be related to the RTTOV. As a result, I changed to intel compiler, the compilation passed without changing anything. I will have another try for gnu+mpt REGTEST run according to your suggestion. Thanks, Wei Zhiquan (Jake) Liu <[email protected]> 于2019年3月16日周六上午11:34写道：

…

@weimmm <https://github.com/weimmm> Can you also run a WRFDA Regtest with gnu+mpt on Cheyenne? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#797 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ApzaKLDVtEs3O8tJyvWok0zJm0EJJRW9ks5vXSsygaJpZM4bVKMA> .

liujake · 2019-03-16T18:21:17Z

@weimmm the file da_read_obs_fy3c.inc needs to be renamed as da_read_obs_hdf5mwhs2.inc following the naming conversion of most other observation files. I understand you followed the existing da_read_obs_fy3.inc (shall be for mwhs and mwts onboard FY3A and FY3B), which needs also to be renamed at some point (NOT in this PR). I believe the same MWHS2 sensor is also onboard the FY3D satellite. Need to make code generic to allow the assimilation of FY3D-MWHS2 as well.

weisunncar · 2019-03-16T18:35:46Z

Dear Dr. Liu, Thank you so much for your suggestion. I will rename the file. Thanks, Wei Zhiquan (Jake) Liu <[email protected]> 于 2019年3月16日周六 12:21写道：

…

@weimmm <https://github.com/weimmm> the file da_read_obs_fy3c.inc needs to be renamed as da_read_obs_hdf5mwhs2.inc following the naming conversion of most other observation files. I understand you followed the existing da_read_obs_fy3.inc (shall be for mwhs and mwts onboard FY3A and FY3B). I believe the same MWHS2 sensor is also onboard the FY3D satellite. Need to make code generic to allow the assimilation of FY3D-MWHS2 as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#797 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ApzaKByG6f3_G3OtVLbMLLWBXwvam_HPks5vXTYggaJpZM4bVKMA> .

liujake · 2019-03-16T20:04:01Z

@weimmm I just ran WRFDA regtest with gnu+mpt with your fy3c branch code. It works for me. I also had some compilation issue from time to time before, but the issue seemed to be related to Cheyenne as manually recompiling WRFDA code worked. See /gpfs/fs1/work/liuz/REGTEST/README.liu for some info.

weisunncar · 2019-03-16T20:52:55Z

Dear Dr. Liu, Thank you so much for your help! I will have a try under my account and let you know the result. Thanks again, Wei Zhiquan (Jake) Liu <[email protected]> 于 2019年3月16日周六 14:04写道：

…

@weimmm <https://github.com/weimmm> I just ran WRFDA regtest with gnu+mpt with your fy3c branch code. It works for me. I also had some compilation issue from time to time before, but the issue seemed to be related to Cheyenne as manually recompiling WRFDA code worked. See /gpfs/fs1/work/liuz/REGTEST/README.liu for some info. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#797 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ApzaKCJkCpF5LTFyfEvAXnqg29pSbRIcks5vXU40gaJpZM4bVKMA> .

TYPE:new feature KEYWORDS: FY3C-MWHS2, Radiance, RTTOV SOURCE: Wei Sun (NSSC,CAS/NCAR) and Jake Liu (NCAR) DESCRIPITION OF CHANGES: Add new capability to assimilate FY3C-MWHS2 Level-1 data in HDF5 format, which can be downloaded from https://satellite.nsmc.org.cn/portalsite. Assimilation of this observation only works with RTTOV, since CRTM has no coefficients corresponding to FY3C. MODIFIED FILES: modified: Registry/registry.var modified: var/da/da_obs_io/da_read_y_unit.inc new file: var/da/da_radiance/da_qc_mwhs2.inc modified: var/da/da_radiance/da_qc_rad.inc modified: var/da/da_radiance/da_radiance.f90 modified: var/da/da_radiance/da_radiance1.f90 modified: var/da/da_radiance/da_radiance_init.inc new file: var/da/da_radiance/da_read_obs_hdf5mwhs2.inc modified: var/da/da_radiance/da_read_pseudo_rad.inc modified: var/da/da_radiance/da_setup_radiance_structures.inc modified: var/da/da_radiance/module_radiance.f90 modified: var/da/da_setup_structures/da_setup_obs_structures.inc modified: var/da/da_setup_structures/da_setup_structures.f90 modified: var/run/VARBC.in new file: var/run/radiance_info/fy3-3-mwhs2.info TEST CONDUCTED: 1. WRFDA regression tests ran successfully with ifort+mpt and gnu+mpt on Cheyenne. 2. New FY3C-MWHS2 radiance DA capability is tested on Cheyenne for 6-hour cycling DA over a 9km domain with a grid mesh of 600*450*50.

…merge Conflicts: var/da/da_radiance/da_qc_mwhs2.inc var/da/da_radiance/da_radiance.f90 var/da/da_radiance/da_setup_radiance_structures.inc

jjguerrette reviewed Feb 27, 2019

View reviewed changes

davegill reviewed Mar 4, 2019

View reviewed changes

davegill added the WRFDA label Mar 4, 2019

liujake added the New Feature label Mar 5, 2019

davegill added the Develop Branch label Mar 9, 2019

liujake requested review from YaliWu0219, liujake and xdmjolly March 16, 2019 17:23

weisunncar added 2 commits March 18, 2019 13:38

Merge branch 'fy3c_merge' of https://github.com/weimmm/WRF into fy3c_…

f3b03c8

…merge Conflicts: var/da/da_radiance/da_qc_mwhs2.inc var/da/da_radiance/da_radiance.f90 var/da/da_radiance/da_setup_radiance_structures.inc

weisunncar requested a review from a team as a code owner March 18, 2019 21:00

delete fy3c

07fc1cd

liujake approved these changes Mar 18, 2019

View reviewed changes

liujake merged commit 637ecb7 into wrf-model:develop Mar 18, 2019

Conversation

weisunncar commented Feb 27, 2019 • edited by liujake Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liujake commented Feb 27, 2019

Uh oh!

jjguerrette left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davegill commented Mar 4, 2019

Uh oh!

liujake commented Mar 5, 2019

Uh oh!

liujake commented Mar 16, 2019

Uh oh!

weisunncar commented Mar 16, 2019 via email

Uh oh!

liujake commented Mar 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weisunncar commented Mar 16, 2019 via email

Uh oh!

liujake commented Mar 16, 2019

Uh oh!

weisunncar commented Mar 16, 2019 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

weisunncar commented Feb 27, 2019 •

edited by liujake

Loading

liujake commented Mar 16, 2019 •

edited

Loading