Warn users when projection is inappropriate for GWD_OPT=1 (merged)#213
Merged
davegill merged 8 commits intowrf-model:masterfrom Mar 31, 2017
davegill:GWD_MERGED_UPDATE
Merged
Warn users when projection is inappropriate for GWD_OPT=1 (merged)#213davegill merged 8 commits intowrf-model:masterfrom davegill:GWD_MERGED_UPDATE
davegill merged 8 commits intowrf-model:masterfrom
davegill:GWD_MERGED_UPDATE
Conversation
TYPE: new feature KEYWORDS: gwd_opt, projection SOURCE: internal DESCRIPTION OF CHANGES: In the WRF model for domain 1, if the projection has a large sinalpha (where it is larger than a default value), notify the user and stop. LIST OF MODIFIED FILES: list of changed files (use `git diff --name-status master` to get formatted list) M dyn_em/start_em.F TESTS CONDUCTED: - [ ] Reggie 3.07, checked means that is has been run
Set value to 22.5 degrees as max (half of 45 degrees), original data at 45 degree directions
2 tasks
mkavulich
approved these changes
Mar 31, 2017
Contributor
mkavulich
left a comment
There was a problem hiding this comment.
Approved by wrf-dev committee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: new feature
KEYWORDS: gwd_opt, projection
SOURCE: internal
DESCRIPTION OF CHANGES:
This PR supersedes PR #208, which was closed.
Assume that the user is trying to use gravity wave drag (GWD),
gwd_opt=1, in the ARW model. For domain 1, if the projection has a large rotation angle anywhere within the domain ("rotation" is directly from the sina variable in the WRF input and output, and "large" means greater than a default value of 22.5o), notify the user and stop. The original GWD data has information at four directions, each separated by 45o angles. Therefore anything larger than a 22.5o projection rotation (usually only violated in parts of the domain) means that the wind components are using the wrong topographic directional information.For the determined user, the namelist variable
max_rot_angle_gwd = 100(really, anything greater than 90o) will always permit GWD to be used, regardless of the projection.How to estimate that the domain will or will not work within the 22.5o restriction:
LIST OF MODIFIED FILES:
M dyn_em/start_em.F
M Registry/Registry.EM_COMMON
TESTS CONDUCTED:
For a domain above the pole, to use gwd_opt=1 NO MATTER WHAT: