Skip to content

Memory-sized arrays changed to tile-sized arrays#1443

Merged
davegill merged 1 commit intowrf-model:developfrom
weiwangncar:ieva_fix
Mar 27, 2021
Merged

Memory-sized arrays changed to tile-sized arrays#1443
davegill merged 1 commit intowrf-model:developfrom
weiwangncar:ieva_fix

Conversation

@weiwangncar
Copy link
Copy Markdown
Collaborator

@weiwangncar weiwangncar commented Mar 26, 2021 •
edited by davegill
Loading

TYPE: bug fix

KEYWORDS: IEVA, tile or memory sized arrays

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Several local arrays used in the implicit advection routines are currently dimensioned by memory sizes. However this
does not affect model results, whether it is serial, OMP or MPI.

Solution:
They should be dimensioned by tile sizes for proper memory scaling using OpenMP.

LIST OF MODIFIED FILES:
M dyn_em/module_ieva_em.F

TESTS CONDUCTED:

  1. It does not change any results.
  2. Jenkins is OK

@weiwangncar weiwangncar changed the base branch from master to develop March 26, 2021 21:10
@davegill
Copy link
Copy Markdown
Contributor

davegill commented Mar 26, 2021

jenkins

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 117a12aafa71a15a063fe4c7562aca3bf7a4771d, requested by: weiwangncar for PR: https://github.com/wrf-model/WRF/pull/1443. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 19           18
    Number of Builds       : 48           46
    Number of Simulations  : 163           161        0
    Number of Comparisons  : 103           102        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None

@davegill
Copy link
Copy Markdown
Contributor

davegill commented Mar 26, 2021

@weiwangncar
I just checked, and I am OK with this PR.

There are places in this file that use i_start < its (and j_start < jts). But neither of those are in the any of the advect_*_implicit routines.

@davegill davegill merged commit a710259 into wrf-model:develop Mar 27, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
@weiwangncar @vlakshmanan-scala
IEVA: change local array dimensions from memory to tile sizes (wrf-mo…
797eb28 
…del#1443)

TYPE: bug fix

KEYWORDS: IEVA, tile or memory sized arrays

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Several local arrays used in the implicit advection routines are currently dimensioned by memory sizes. However this 
does not affect model results, whether it is serial, OMP or MPI.

Solution:
They should be dimensioned by tile sizes for proper memory scaling using OpenMP.

LIST OF MODIFIED FILES: 
M    dyn_em/module_ieva_em.F

TESTS CONDUCTED: 
1. It does not change any results.
2. Jenkins is OK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brankokosovic brankokosovic Awaiting requested review from brankokosovic

@domingom domingom Awaiting requested review from domingom

@pedro-jm pedro-jm Awaiting requested review from pedro-jm

1 more reviewer

@davegill davegill davegill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Develop Branch PHYSICS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weiwangncar @davegill