Skip to content

Add new options to readme#1438

Merged
kkeene44 merged 3 commits intowrf-model:developfrom
kkeene44:add_new_options_to_readme
Mar 22, 2021
Merged

Add new options to readme#1438
kkeene44 merged 3 commits intowrf-model:developfrom
kkeene44:add_new_options_to_readme

Conversation

@kkeene44
Copy link
Copy Markdown
Collaborator

@kkeene44 kkeene44 commented Mar 18, 2021

TYPE: text only

KEYWORDS: README.namelist, wudapt, rebalance, madwrf, P3, CTSM

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Several new namelist options have been added to the code for the V4.3 release, but a few weren't added to the README.namelist file.

Solution:
Added the missing namelist variables to the README.namelist file.

LIST OF MODIFIED FILES:
M run/README.namelist

TESTS CONDUCTED:

  1. no tests necessary - text only
  2. Jenkins are all passing.

@kkeene44 kkeene44 requested review from a team as code owners March 18, 2021 18:14
@kkeene44 kkeene44 changed the base branch from master to develop March 18, 2021 18:15
@kkeene44 kkeene44 removed request for a team March 18, 2021 18:15
@weiwangncar
Copy link
Copy Markdown
Collaborator

@kkeene44 The lines look good now.

Copy link
Copy Markdown
Contributor

@davegill davegill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@weiwangncar
Copy link
Copy Markdown
Collaborator

@davegill We don't need this option anymore: max_rot_angle_gwd.

@kkeene44 kkeene44 force-pushed the add_new_options_to_readme branch from 7f29351 to 1524603 Compare March 22, 2021 16:15
@davegill
Copy link
Copy Markdown
Contributor

@kkeene44 @weiwangncar
Kelly,
I am satisfied that this GWD variable can be removed.

find . -name \*.F -exec grep -i max_rot_angle_gwd {} \; -print

finds nothing. This is with a recent version of the develop branch:

git branch
* develop
  master

@kkeene44 kkeene44 merged commit 46d07e6 into wrf-model:develop Mar 22, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
TYPE: text only

KEYWORDS: README.namelist, wudapt, rebalance, madwrf, P3, CTSM

SOURCE: internal

DESCRIPTION OF CHANGES:
Problem:
Several new namelist options have been added to the code for the V4.3 release, but a few weren't added to the README.namelist file.

Solution:
Added the missing namelist variables to the README.namelist file.

LIST OF MODIFIED FILES:
M run/README.namelist

TESTS CONDUCTED:

no tests necessary - text only
Jenkins are all passing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants