Skip to content

urban updates: solar panel, green roof, building drag coefficient#1427

Merged
davegill merged 9 commits intowrf-model:developfrom
davegill:develop+urban
Mar 5, 2021
Merged

urban updates: solar panel, green roof, building drag coefficient#1427
davegill merged 9 commits intowrf-model:developfrom
davegill:develop+urban

Conversation

@davegill
Copy link
Copy Markdown
Contributor

@davegill davegill commented Mar 4, 2021 •
edited by weiwangncar
Loading

KEYWORDS: urban, green roof, solar panel, new building drag coefficient

SOURCE: Andrea Zonato (University of Trento, Italy, [email protected])

DESCRIPTION OF CHANGES:
This update includes new capabilities to account for urban solar panel, green roof, and new building drag coefficient. These three new capabilities are for BEP+BEM. The new building drag coefficient is based on Santiago and Martilli (2010) and Guti ́errez et al. (2015). More details are available in the WRF User's Guide.

LIST OF MODIFIED FILES:
M Registry/Registry.EM_COMMON
M Registry/Registry.NMM
M Registry/registry.dimspec
M dyn_em/module_first_rk_step_part1.F
M dyn_em/start_em.F
M dyn_nmm/module_PHYSICS_CALLS.F
M dyn_nmm/start_domain_nmm.F
M phys/module_physics_init.F
M phys/module_sf_bem.F
M phys/module_sf_bep_bem.F
M phys/module_sf_noahdrv.F
M phys/module_sf_noahmpdrv.F
M phys/module_sf_urban.F
M phys/module_surface_driver.F
M run/URBPARM.TBL
M run/URBPARM_LCZ.TBL
M share/module_check_a_mundo.F

TESTS CONDUCTED:

  1. The model compilation has been tested successfully (tested in Cheyenne by both the developer and Cenlin He, NCAR)
  2. The model simulation has been tested successfully (tested in Cheyenne by the developer)
  3. The model simulation has been tested successfully (tested in WRF Docker by Cenlin He, NCAR)
  4. The jenkins testing is all PASS

The original PR was split into two pieces. Here is a figure from the original PR (left) and the combination of the two PRs
(right). We want to see nearly the exact same features. This is a figure of 2-meter temperature around the Denver area.

T2_example_urbanPR

RELEASE NOTE: WRF-urban updates for green roof, solar panel, and new building drag coefficient for BEP+BEM. The paper describing the green roof update is under development. The new building drag coefficient is based on Santiago and Martilli (2010) and Guti ́errez et al. (2015).
Santiago, J. L. and Martilli, A. (2010). A Dynamic Urban Canopy Parameterization for Mesoscale Models Based on Computational Fluid Dynamics Reynolds-Averaged Navier-Stokes Microscale Simulations. Boundary- Layer Meteorology, 137(3):417–439.
Guti ́errez, E., Martilli, A., Santiago, J. L., and Gonz ́alez, J. E. (2015). A Mechanical Drag Coefficient Formulation and Urban Canopy Parameter Assimilation Technique for Complex Urban Environments. Boundary-Layer Meteorology, 157(2):333–341.
A. Zonato, A. Martilli, E. Gutierrez, F. Chen, C. He, M. Barlage, D. Zardi, and L. Giovannini (2021): Exploring the effects of rooftop mitigation strategies on urban temperatures and energy consumption, Atmospheric Chemistry and Physics, under review.

Andrea Zonato and others added 5 commits January 26, 2021 03:24
implementation of LCZ, Green Roof, Photovoltaic panels, new building …
a33b5f3 
…drag coefficient, diffuse and direct radiation and building materials permeability in BEP+BEM /sf_urban_physics=3)
Solved bugs on use_wudapt_lcz
dc4a843
Solved - issue on Registry.EM_COMMON
9754795
@andreazonato
Modification of nz_um=18,nbu_max=15
8cac4ef
@davegill
Merge branch 'WRF_GREENROOF_LCZ' into develop+urban
99624e8 
Conflicts:
	Registry/Registry.EM_COMMON
	dyn_em/module_initialize_real.F
	phys/module_physics_init.F
	phys/module_sf_bep.F
	phys/module_sf_bep_bem.F
	phys/module_sf_noahdrv.F
	phys/module_sf_noahmpdrv.F
	phys/module_sf_noahmplsm.F
	phys/module_sf_urban.F
	phys/module_surface_driver.F
	run/URBPARM.TBL
	run/URBPARM_LCZ.TBL

 Changes to be committed:

	modified:   Registry/Registry.EM_COMMON
	modified:   Registry/Registry.NMM
	modified:   Registry/registry.dimspec
	modified:   dyn_em/module_first_rk_step_part1.F
	modified:   dyn_em/start_em.F
	modified:   dyn_nmm/module_PHYSICS_CALLS.F
	modified:   dyn_nmm/start_domain_nmm.F
	modified:   phys/module_physics_init.F
	modified:   phys/module_sf_bem.F
	modified:   phys/module_sf_bep_bem.F
	modified:   phys/module_sf_noahdrv.F
	modified:   phys/module_sf_noahmpdrv.F
	modified:   phys/module_sf_urban.F
	modified:   phys/module_surface_driver.F
	modified:   run/URBPARM.TBL
	modified:   run/URBPARM_LCZ.TBL
	modified:   share/module_check_a_mundo.F
@davegill davegill requested review from a team as code owners March 4, 2021 01:26
@davegill
Copy link
Copy Markdown
Contributor Author

davegill commented Mar 4, 2021

jenkins

Please find result of the WRF regression test cases in the attachment. This build is for Commit ID: 603f79b087293bad4f56144cc9fad1c104f95a02, requested by: davegill for PR: https://github.com/wrf-model/WRF/pull/1427. For any query please send e-mail to David Gill.

    Test Type              | Expected  | Received |  Failed
    = = = = = = = = = = = = = = = = = = = = = = = =  = = = =
    Number of Tests        : 19           18
    Number of Builds       : 48           46
    Number of Simulations  : 163           161        0
    Number of Comparisons  : 103           102        0

    Failed Simulations are: 
    None
    Which comparisons are not bit-for-bit: 
    None

@davegill davegill changed the title Develop+urban: green roof, solar, etc urban updates: solar panel, green roof, building drag coefficient Mar 4, 2021
@davegill
Copy link
Copy Markdown
Contributor Author

davegill commented Mar 4, 2021 •
edited
Loading

@andreazonato @cenlinhe @dudhia @weiwangncar
This PR is a modification to the develop branch, and the develop branch already contains the LCZ mods.
With this fork and branch, the original tests may be conducted to determine if this code is giving the right answers.

@davegill davegill mentioned this pull request Mar 4, 2021
Closed
@cenlinhe
Copy link
Copy Markdown
Contributor

cenlinhe commented Mar 4, 2021

@davegill Dave, did you mean you solved the conflicts regarding the LCZ part in this new PR by using the updated LCZ code that has been already merged into the develop branch to replace the LCZ part in the PR #1385 ?

@davegill
Copy link
Copy Markdown
Contributor Author

davegill commented Mar 4, 2021

@cenlinhe

you solved the conflicts regarding the LCZ part in this new PR by using the updated LCZ code that has been already merged into the develop branch

Yes, I think that this PR is what we want.

It passes the standard jenkins tests. However, we need to see that the results are physically reasonable when the new features are activated. We would like to cut off the release branch from the develop branch this week, so testing is a priority.

@cenlinhe
Copy link
Copy Markdown
Contributor

cenlinhe commented Mar 4, 2021

I will try to do tests for this PR code tonight and tomorrow morning.

dudhia
dudhia reviewed Mar 4, 2021
View reviewed changes
dudhia
dudhia reviewed Mar 4, 2021
View reviewed changes
dudhia
dudhia reviewed Mar 4, 2021
View reviewed changes
dudhia
dudhia reviewed Mar 4, 2021
View reviewed changes
dudhia
dudhia reviewed Mar 4, 2021
View reviewed changes
dudhia
dudhia reviewed Mar 4, 2021
View reviewed changes
@andreazonato
Copy link
Copy Markdown
Contributor

andreazonato commented Mar 4, 2021 via email

@cenlinhe
Copy link
Copy Markdown
Contributor

cenlinhe commented Mar 4, 2021 •
edited
Loading

@davegill @andreazonato Hi Andrea, I think you can put the reference here and ask Dave to include it in the release note of the PR message above. Although it is under review, you can still put the authors, paper title, journal name, and "under review".

dudhia
dudhia reviewed Mar 4, 2021
View reviewed changes
phys/module_sf_bem.F Outdated
real em_av !averadge emissivity
real twal_int(6) !twalint
real em_av !averadge emissivity
real twal_int(6) !twalint
Copy link
Copy Markdown
Collaborator

@dudhia dudhia Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent increased

Copy link
Copy Markdown
Contributor Author

@davegill davegill Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jimy,
I lined up these also. There were tabs vs spaces used here. I have followed the existing convention, and they should line up nicely now.

Copy link
Copy Markdown
Contributor Author

@davegill davegill Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jimy,
Here is what the source code looks like in an editor on my Mac:

        integer iw,jw
        real b_wall(6)  
        real b_wind(6)
        real emwal_av           !averadge emissivity of the wall
        real emwin_av           !averadge emissivity of the window
        real em_av              !averadge emissivity
        real twal_int(6)        !twalint 
        real twin(4)            !twinint

The github representation is playing with tabs and spaces. My editor will not allow me to introduce a tab character in the source code.

@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Mar 4, 2021 via email

@cenlinhe
Copy link
Copy Markdown
Contributor

cenlinhe commented Mar 4, 2021

@davegill @dudhia @weiwangncar I have done a few tests using this PR code and all urban physics options work well. I checked key land surface variables (e.g., temperature, heat flux, radiation, etc.) and the results look reasonable: /glade/scratch/cenlinhe/WRF_noahmp_test/WRF_LCZ_urban1427/run/urban*/

@cenlinhe
Copy link
Copy Markdown
Contributor

cenlinhe commented Mar 4, 2021

This is the under-review paper Andrea mentioned which discussed this urban code update here: A. Zonato, A. Martilli, E. Gutierrez, F. Chen, C. He, M. Barlage, D. Zardi, and L. Giovannini (2021): Exploring the effects of rooftop mitigation strategies on urban temperatures and energy consumption, Atmospheric Chemistry and Physics, under review.

@davegill
Copy link
Copy Markdown
Contributor Author

davegill commented Mar 4, 2021

@cenlinhe @dudhia @weiwangncar

I have done a few tests using this PR code and all urban physics options work well. I checked key land surface variables (e.g., temperature, heat flux, radiation, etc.) and the results look reasonable

Cenlin,
Thanks for jumping on this so quickly. I think that we are now good to go.

Wei and Jimy,
The comments so far about incorrect spaces (etc) were on purpose to align the columns and fix indenting in the original code. This is ready for a review.

@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Mar 4, 2021 via email

@davegill
aethetics - fix some indenting
8825978 
modified:   phys/module_sf_bem.F
modified:   phys/module_sf_bep_bem.F
@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Mar 4, 2021

Thanks. I had one comment left in the BEP-BEM module.

@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Mar 4, 2021 via email

@davegill
Copy link
Copy Markdown
Contributor Author

davegill commented Mar 4, 2021

@dudhia
Several of the suggestions for indenting that you had that actually put the code back to where it was supposed to be, and removed that line from any diff. There were a couple of these in BEM, and the newer indenting suggestion that you pointed out in BEP_BEM.

@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Mar 4, 2021 via email

@dudhia
Copy link
Copy Markdown
Collaborator

dudhia commented Mar 4, 2021 via email

@davegill davegill merged commit d994880 into wrf-model:develop Mar 5, 2021
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
@davegill @vlakshmanan-scala
urban updates: solar panel, green roof, building drag coefficient (wr…
6d7f7f7 
…f-model#1427)

KEYWORDS: urban, green roof, solar panel, new building drag coefficient

SOURCE: Andrea Zonato (University of Trento, Italy, [email protected])

DESCRIPTION OF CHANGES:
This update includes new capabilities to account for urban solar panel, green roof, and new building drag coefficient. 
These three new capabilities are for BEP+BEM. The new building drag coefficient is based on Santiago and Martilli 
(2010) and Guti ́errez et al. (2015). More details are available in the WRF User's Guide. 


LIST OF MODIFIED FILES: 
M Registry/Registry.EM_COMMON
M Registry/Registry.NMM
M Registry/registry.dimspec
M dyn_em/module_first_rk_step_part1.F
M dyn_em/start_em.F
M dyn_nmm/module_PHYSICS_CALLS.F
M dyn_nmm/start_domain_nmm.F
M phys/module_physics_init.F
M phys/module_sf_bem.F
M phys/module_sf_bep_bem.F
M phys/module_sf_noahdrv.F
M phys/module_sf_noahmpdrv.F
M phys/module_sf_urban.F
M phys/module_surface_driver.F
M run/URBPARM.TBL
M run/URBPARM_LCZ.TBL
M share/module_check_a_mundo.F

TESTS CONDUCTED:
1. The model compilation has been tested successfully (tested in Cheyenne by both the developer and Cenlin He, NCAR)
2. The model simulation has been tested successfully (tested in Cheyenne by the developer)
3. The model simulation has been tested successfully (tested in WRF Docker by Cenlin He, NCAR)
4. The jenkins testing is all PASS

The original PR was split into two pieces. Here is a figure from the original PR (left) and the combination of the two PRs 
(right). We want to see nearly the exact same features. This is a figure of 2-meter temperature around the Denver area.

![T2_example_urbanPR](https://user-images.githubusercontent.com/12666234/110049573-5214ac00-7d0f-11eb-87ba-75591a893b80.png)


RELEASE NOTE: WRF-urban updates for green roof, solar panel, and new building drag coefficient for BEP+BEM. The paper describing the green roof update is under development. The new building drag coefficient is based on Santiago and Martilli (2010) and Guti ́errez et al. (2015).
Santiago, J. L. and Martilli, A. (2010). A Dynamic Urban Canopy Parameterization for Mesoscale Models Based on Computational Fluid Dynamics Reynolds-Averaged Navier-Stokes Microscale Simulations. Boundary- Layer Meteorology, 137(3):417–439.
Guti ́errez, E., Martilli, A., Santiago, J. L., and Gonz ́alez, J. E. (2015). A Mechanical Drag Coefficient Formulation and Urban Canopy Parameter Assimilation Technique for Complex Urban Environments. Boundary-Layer Meteorology, 157(2):333–341.
A. Zonato, A. Martilli, E. Gutierrez, F. Chen, C. He, M. Barlage, D. Zardi, and L. Giovannini (2021): Exploring the effects of rooftop mitigation strategies on urban temperatures and energy consumption, Atmospheric Chemistry and Physics, under review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dudhia dudhia dudhia approved these changes

Assignees

No one assigned

Labels

Develop Branch New Feature PHYSICS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davegill @cenlinhe @andreazonato @dudhia