Thompson MP: reduce fake aerosol emissions by 4x#1423
Merged
davegill merged 2 commits intowrf-model:developfrom Mar 3, 2021
Merged
Thompson MP: reduce fake aerosol emissions by 4x#1423davegill merged 2 commits intowrf-model:developfrom
davegill merged 2 commits intowrf-model:developfrom
Conversation
Changes to be committed: modified: phys/module_mp_thompson.F
Contributor
Author
|
replaces #1420 "Thompson MP: reduce fake aerosol emissions by 4x". The develop branch had a bug, causing regression failures |
Contributor
Author
|
@gthompsnWRF |
Contributor
|
@gthompsnWRF @davegill @dudhia Should this multiplier also be modified in dyn_em/module_initialize_real.F ? |
Contributor
Author
|
@twjuliano |
Contributor
Did I really miss that? Yes, it definitely should be altered. Now, I need to see if it was ever needed in the thompson_initialize routine and I goofed on where to place it. Yikes and ugh! |
Contributor
|
@gthompsnWRF From my understanding, it is still needed in thompson_init if the user is running mp=28 & related namelist options for 1) an idealized case or 2) a real case with no aerosol inputs in met_em. So, I think it looks OK :-) |
davegill
added a commit
that referenced
this pull request
May 7, 2021
…#1507) TYPE: bug fix KEYWORDS: Thompson, aerosol, emission SOURCE: Laura Fowler, Mary Barth, Tim Juliano (NCAR), Greg Thompson (JCSDA), internal DESCRIPTION OF CHANGES: Problem: In commit c54cc0a, PR #1423 "Thompson MP: reduce fake aerosol emissions by 4x", a change was made to the "fake" surface aerosols for the Thompson MP scheme. A required similar change was accidentally not included in the initialization step of these idealized aerosols for ARW real. Solution: Add the same mods to the fake surface number concentration of water friendly aerosols in the ARW real program. LIST OF MODIFIED FILES: modified: dyn_em/module_initialize_real.F TESTS CONDUCTED: 1. The developer proposed these mods. 2. Jenkins tests are all PASS.
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: Thompson, MP, aerosol, constant SOURCE: Greg Thompson (JCSDA), found by Laura Fowler and Mary Barth (NCAR) DESCRIPTION OF CHANGES: A problem with a single constant was discovered a couple months ago, but did not get permanently updated in the repository. The fix is to reduce fake surface aerosol emissions by a factor of 4. LIST OF MODIFIED FILES: modified: phys/module_mp_thompson.F TESTS CONDUCTED: 1. Jenkins tests are all PASS. RELEASE NOTE: For the Thompson MP scheme, a problem with a single constant was discovered that caused approximately 4x too much fake surface aerosol emissions.
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…wrf-model#1507) TYPE: bug fix KEYWORDS: Thompson, aerosol, emission SOURCE: Laura Fowler, Mary Barth, Tim Juliano (NCAR), Greg Thompson (JCSDA), internal DESCRIPTION OF CHANGES: Problem: In commit c54cc0a, PR wrf-model#1423 "Thompson MP: reduce fake aerosol emissions by 4x", a change was made to the "fake" surface aerosols for the Thompson MP scheme. A required similar change was accidentally not included in the initialization step of these idealized aerosols for ARW real. Solution: Add the same mods to the fake surface number concentration of water friendly aerosols in the ARW real program. LIST OF MODIFIED FILES: modified: dyn_em/module_initialize_real.F TESTS CONDUCTED: 1. The developer proposed these mods. 2. Jenkins tests are all PASS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: Thompson, MP, aerosol, constant
SOURCE: Greg Thompson (JCSDA), found by Laura Fowler and Mary Barth (NCAR)
DESCRIPTION OF CHANGES:
A problem with a single constant was discovered a couple months ago, but did not get permanently updated in the
repository. The fix is to reduce fake surface aerosol emissions by a factor of 4.
LIST OF MODIFIED FILES:
modified: phys/module_mp_thompson.F
TESTS CONDUCTED:
RELEASE NOTE: For the Thompson MP scheme, a problem with a single constant was discovered that caused approximately 4x too much fake surface aerosol emissions.