Fix return type on wrf_dm_max_int (should be an integer)#1339
Merged
davegill merged 1 commit intowrf-model:release-v4.2.2from Jan 7, 2021
Merged
Fix return type on wrf_dm_max_int (should be an integer)#1339davegill merged 1 commit intowrf-model:release-v4.2.2from
davegill merged 1 commit intowrf-model:release-v4.2.2from
Conversation
TYPE: bug fix KEYWORDS, real, int, integer, wrf_dm_max_int SOURCE: internal DESCRIPTION OF CHANGES: While looking to see if WRF had a function to return the maximum integer from among the max values of integers on each of the MPI ranks, it was noticed that the return value for the existing function was REAL. It should be an INTEGER. There is only a single use of this function in the entire model, in the file `share/module_trajectory.F`. ``` glb_traj_proc(trj) = wrf_dm_max_int( traj_proc(trj) ) ``` In that file, the input to the function, `traj_proc`, and the return value, `glb_traj_proc`, are both declared as integers. ``` integer :: traj_proc(traj_max), glb_traj_proc(traj_max) ``` LIST OF MODIFIED FILES: M external/RSL_LITE/module_dm.F TESTS CONDUCTED: 1. Maybe I can figure out how to do a trajectory test, maybe.
Contributor
Author
|
@smileMchen |
Collaborator
|
@davegill |
smileMchen
approved these changes
Jan 7, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS, real, int, integer, wrf_dm_max_int SOURCE: internal DESCRIPTION OF CHANGES: While looking to see if WRF had a function to return the maximum integer from among the max values of integers on each of the MPI ranks, it was noticed that the return value for the existing function was REAL. It should be an INTEGER. There is only a single use of this function in the entire model, in the file `share/module_trajectory.F`. ``` glb_traj_proc(trj) = wrf_dm_max_int( traj_proc(trj) ) ``` In that file, the input to the function, `traj_proc`, and the return value, `glb_traj_proc`, are both declared as integers. Therefore, there is no reason for a function to be given a list of integers, and when finding the max value to actually return that value as a real. ``` integer :: traj_proc(traj_max), glb_traj_proc(traj_max) ``` LIST OF MODIFIED FILES: M external/RSL_LITE/module_dm.F TESTS CONDUCTED: 1. Jenkins tests OK. 2. A small set of trajectories works as expected. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS, real, int, integer, wrf_dm_max_int
SOURCE: internal
DESCRIPTION OF CHANGES:
While looking to see if WRF had a function to return the maximum integer from among the
max values of integers on each of the MPI ranks, it was noticed that the return value for the
existing function was REAL. It should be an INTEGER.
There is only a single use of this function in the entire model, in the file
share/module_trajectory.F.In that file, the input to the function,
traj_proc, and the return value,glb_traj_proc, are both declared as integers. Therefore, there is no reason for a function to be given a list of integers, and when finding the max value to actually return that value as a real.LIST OF MODIFIED FILES:
M external/RSL_LITE/module_dm.F
TESTS CONDUCTED: