Merged
Conversation
weiwangncar
approved these changes
Nov 4, 2020
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
…rf-model#1313) TYPE: bug fix KEYWORDS: sea-ice fraction option, QSFC calculation, MYJSFC, QNSESFC SOURCE: Xin-Zhong Liang DESCRIPTION OF CHANGES: Problem: Incorrect parentheses in weighted average Solution: Fixed parentheses Effect: Test by Kevin Manning indicates small effect. ISSUE: For use when this PR closes an issue. Fixes wrf-model#1297 (part) LIST OF MODIFIED FILES: M phys/module_surface_driver.F TESTS CONDUCTED: Test by Kevin Manning shows small impact. Jenkins test (TBD) RELEASE NOTE: Fix incorrect parentheses in weighted average for QSFC when sea-ice fraction is used with MYJSFC and QNSESFC surface layer physics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: sea-ice fraction option, QSFC calculation, MYJSFC, QNSESFC
SOURCE: Xin-Zhong Liang
DESCRIPTION OF CHANGES:
Problem: Incorrect parentheses in weighted average
Solution:
Fixed parentheses
Effect: Test by Kevin Manning indicates small effect.
ISSUE: For use when this PR closes an issue.
Fixes #1297 (part)
LIST OF MODIFIED FILES:
M phys/module_surface_driver.F
TESTS CONDUCTED:
Test by Kevin Manning shows small impact.
Jenkins test (TBD)
RELEASE NOTE:
Fix incorrect parentheses in weighted average for QSFC when sea-ice fraction is used in myjsfc_seaice_wrapper and qnsesfc_seaice_wrapper.