Fix DA use_obs_errfac for multiple outerloops#1288
Merged
jamiebresch merged 1 commit intowrf-model:release-v4.2.2from Sep 18, 2020
Merged
Fix DA use_obs_errfac for multiple outerloops#1288jamiebresch merged 1 commit intowrf-model:release-v4.2.2from
jamiebresch merged 1 commit intowrf-model:release-v4.2.2from
Conversation
modified: var/da/da_minimisation/da_get_innov_vector.inc
liujake
approved these changes
Sep 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: WRFDA, use_obs_errfac, max_ext_its > 1
SOURCE: Jamie Bresch (NCAR)
DESCRIPTION OF CHANGES:
Problem:
CWB reported seeing obs errors keep decreasing with each outerloop.
Solution:
Add a check for outerloop number, so that when use_obs_errfac=true and errfac.dat exists in the working directory, observation error factors are applied only at the first outerloop.
LIST OF MODIFIED FILES:
M var/da/da_minimisation/da_get_innov_vector.inc
TESTS CONDUCTED:
RELEASE NOTE: Bug fix for WRFDA's incorrectly applying errfac.dat at each outerloop when use_obs_errfac=true and max_ext_its > 1.