Update the minimum required WP version for plugins#103
Merged
irshadahmad21 merged 2 commits intomainfrom Feb 19, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 7522074 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of our users reported that the settings page is blank. Upon investigating, we found that the user was on WP 6.3.3 and we had mentioned the minimum requirement to be WP 6.2.
The reason for that blank page was that the settings JS script needs
type="module"attribute which is set byWPSocio\WPUtils\ViteWPReactAssets.WPSocio\WPUtils\ViteWPReactAssetsuseswp_script_attributesfilter (used bywp_get_script_tag) that WordPress falsely mentions to be available since WP 5.7, while in reality it is used only since WP 6.4 and it is not available till WP 6.3.3.Thus, we are changing the minimum WP requirement to 6.4.