fix: dont overload NodeWithEditorBlocks.flat
#246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6de0fde The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
theodesp
previously approved these changes
Jun 20, 2024
Member
|
@justlevine we might need to resolve the conflicts before merging thanks! |
Contributor
Author
theodesp
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR removes the unnecessary
flatarg definition fromNodeWith{$Post_Type}EditorBlocks, instead relying on the arg definition set by the parentNodeWithEditorBlocks.Why
The real reason is that there is no difference between the parent and child implementations, so there's no reason to overload.
The superficial reason is that it works around a WPGraphQL core regression wp-graphql/wp-graphql#3152 which:
graphql-schema-linter.Screenshots
Look ma no
extension.debugmessages