Fixes #3003 Prevent fatal error following WooCommerce 4.4 update#3004
Merged
remyperona merged 11 commits intomasterfrom Aug 18, 2020
Merged
Fixes #3003 Prevent fatal error following WooCommerce 4.4 update#3004remyperona merged 11 commits intomasterfrom
remyperona merged 11 commits intomasterfrom
Conversation
…nto hotfix/composer-compatibility
remyperona
added
priority: 🔥critical
adjust integration tests to check on the version of WP to assert existence of jquery-migrate or not (PR #2991)
iCaspar
approved these changes
Aug 18, 2020
hellofromtonya
approved these changes
Aug 18, 2020
Contributor
|
@Davidacu Ready for QA. Please ping us in Slack when done. |
engahmeds3ed
approved these changes
Aug 18, 2020
Davidacu
approved these changes
Aug 18, 2020
Davidacu
left a comment
Davidacu
left a comment
There was a problem hiding this comment.
- I can confirm that the fatal error notice is no longer displayed after updating wp rocket with this new version.
- Woocomerce 4.4.0 is functional.
- No issues or notices found in the logs.
- WP Rocket Smoke/regression tests Passed:
Minify HTML/CSS/JS
Combine CSS/JS
Optimize CSS delivery
Lazy loading
google tracking addon
CDN replacement
Load JS deferred
Optimize Google fonts.
Varnish Addon detection in O2switch
Varnish Addon detection in Savvii
Comments/Posts/Transients clean up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Namespace the container inside our own namespace to prevent conflict when WooCommerce 4.4 uses league/container version 3
Also prevent the PHP notice related to the REST API with WP 5.5