Adjust tests not to support jquery-migrate after WP version 5.5#2991
Merged
engahmeds3ed merged 1 commit intodevelopfrom Aug 12, 2020
Merged
Adjust tests not to support jquery-migrate after WP version 5.5#2991engahmeds3ed merged 1 commit intodevelopfrom
engahmeds3ed merged 1 commit intodevelopfrom
Conversation
…tence of jquery-migrate or not
engahmeds3ed
changed the title
remyperona
approved these changes
Aug 12, 2020
remyperona
pushed a commit
that referenced
this pull request
Aug 18, 2020
adjust integration tests to check on the version of WP to assert existence of jquery-migrate or not (PR #2991)
remyperona
pushed a commit
that referenced
this pull request
Aug 18, 2020
…3004) * add Container classes * replace League\Container with WP_Rocket\Engine\Container * Add permissions_callback to RESTSubscriber routes * Fix syntax error * update container namespace in our files * update composer.json not to require League Container * update plugin version * add container dependency * Adjust tests not to support jquery-migrate after WP version 5.5 PR #2991 * ignore Container directory Co-authored-by: Ahmed Saeed <[email protected]> Co-authored-by: Caspar Green <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2990
Wordpress from version 5.5 stopped support for jquery-migrate script out of the box so we need to adjust the code/tests to check the wordpress version if greater than or equals 5.5 so do the followings:-
Adjust the tests not to expect this script to be returned from WP.