feat: update docs Date fields to link to the RFC3339 spec #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ster_graphql_acf_field_type`, allowing for a string or callback to be passed that will append a string to the description which is populated by the field graphql_description or instructions field. - implements this on the DatePicker and DateTimePicker field types to show that the string will be output in RFC3339 format - updates the description of the startDate and endDate fields of the ACFE_Date_Range type to include a link to the RFC3339 spec
…contain a string but might not equal it exactly
- add translators: comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This updates the GraphQL field descriptions for fields of the DatePicker and DateTimePicker ACF field type to indicate that the strings returned will be formatted in RFC3339 format.
This is helpful for client developers to know how they can expect to interact with the resulting value.
Does this close any currently open issues?
closes #161
Any other comments?
In the WPGraphQL IDE we can see the field descriptions now include a link to the RFC3339 spec and a description that the field will return according to that spec.
