fix: Taxonomy field returns incorrect data if set to store objects instead of IDs #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esolver returns incorrect information. This resolves that by accounting for IDs or Objects being stored and returned.
…taxonomy-field-not-handling-objects-properly
…ect vs id & array vs individual value) - add test for Taxonomy field when 'object' is set as the return type
Pull Request Test Coverage Report for Build 6b5ba619b0caedb22501d15572c6ba5c41d692fa-PR-178Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
When an ACF Field of the "Taxonomy" type field is set to store objects instead of IDs:
The resolver returns incorrect information. This resolves that by accounting for IDs or Objects being stored and returned.
Does this close any currently open issues?
closes #177
Any other comments?
(see issue #177 for the scenario)
With the following term saved in the "rubrique" field:
Before:
The "Uncategorized" term is resolved (not expected behavior)
After:
The expected term is resolved: