fix: taxonomy field resolves sorted in the incorrect order #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release: v2.1.1
…s are saved - update taxonomy field resolver to se the default order and orderby when resolving with the TermObjectConnectionResolver
3 tasks
Pull Request Test Coverage Report for Build 4d75e4965c3416b8369ea2f446f5370f2948f1a1-PR-174Details
💛 - Coveralls |
josephfusco
approved these changes
Feb 14, 2024
Comment on lines
+96
to
+192
| public function testQueryReturnsTermsInOrderTheyWereSaved() { | ||
|
|
||
| $field_key = $this->register_acf_field([ | ||
| 'type' => 'taxonomy', | ||
| 'name' => 'tax_term_order_test', | ||
| 'show_in_graphql' => true, | ||
| 'graphql_field_name' => 'termOrderTest', | ||
| 'required' => 1, | ||
| 'taxonomy' => 'category', | ||
| 'add_term' => 0, | ||
| 'save_terms' => 0, | ||
| 'load_terms' => 0, | ||
| 'return_format' => 'id', | ||
| 'field_type' => 'multi_select', | ||
| 'multiple' => 1, | ||
| 'bidirectonal' => 0, | ||
| 'bidirectional_target' => [], | ||
| ], [ | ||
| 'name' => 'Taxonomy Order Test', | ||
| 'graphql_field_name' => 'TaxonomyOrderTest', | ||
| 'location' => [ | ||
| [ | ||
| [ | ||
| 'param' => 'post_type', | ||
| 'operator' => '==', | ||
| 'value' => 'post', | ||
| ] | ||
| ] | ||
| ], | ||
| 'graphql_types' => [ 'Post' ], | ||
| ]); | ||
|
|
||
| $cat_aaa = self::factory()->category->create([ | ||
| 'name' => 'AAA' | ||
| ]); | ||
|
|
||
| $cat_bbb = self::factory()->category->create([ | ||
| 'name' => 'BBB' | ||
| ]); | ||
|
|
||
| $cat_ccc = self::factory()->category->create([ | ||
| 'name' => 'CCC' | ||
| ]); | ||
|
|
||
| $cats = [$cat_ccc, $cat_aaa, $cat_bbb]; | ||
|
|
||
| update_field( $field_key, $cats, $this->published_post ); | ||
|
|
||
| $query = ' | ||
| query GetPost($id:ID!) { | ||
| post(id:$id idType:DATABASE_ID) { | ||
| id | ||
| databaseId | ||
| taxonomyOrderTest { | ||
| termOrderTest { | ||
| nodes { | ||
| __typename | ||
| databaseId | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| '; | ||
|
|
||
| $actual = $this->graphql([ | ||
| 'query' => $query, | ||
| 'variables' => [ | ||
| 'id' => $this->published_post->ID, | ||
| ] | ||
| ]); | ||
|
|
||
| codecept_debug( [ | ||
| '$actual' => $actual, | ||
| '$cats' => $cats, | ||
| ]); | ||
|
|
||
| self::assertQuerySuccessful( $actual, [ | ||
| $this->expectedNode( 'post.taxonomyOrderTest.termOrderTest.nodes', [ | ||
| '__typename' => 'Category', | ||
| 'databaseId' => $cats[0] | ||
| ], 0 ), | ||
| $this->expectedNode( 'post.taxonomyOrderTest.termOrderTest.nodes', [ | ||
| '__typename' => 'Category', | ||
| 'databaseId' => $cats[1] | ||
| ], 1 ), | ||
| $this->expectedNode( 'post.taxonomyOrderTest.termOrderTest.nodes', [ | ||
| '__typename' => 'Category', | ||
| 'databaseId' => $cats[2] | ||
| ], 2 ), | ||
| ]); | ||
|
|
||
| foreach ( $cats as $cat ) { | ||
| wp_delete_term( $cat, 'category' ); | ||
| } | ||
|
|
||
| } |
jasonbahl
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
fixes the sort order for querying fields of the taxonomy type.
Does this close any currently open issues?
closes #171
Any other comments?
Given a field of the "taxonomy" type set as a "multi select" and multiple terms stored:
Before
Querying the field would return the nodes ordered by name
After
Querying the field returns the nodes in the same order they're saved