fix: user field returning all publicly queryable users #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on a node - update test suite to add a published post by editor and published post by author so that more than 1 user are public in the environment - update textFieldTest to test querying the text field on a post - update UserFieldTest to test querying the user field (failing test)
Pull Request Test Coverage Report for Build e652a10e2d4dcff26882063ea14365f5eed7c8a2-PR-165
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fixes a bug where the "user" field would return all public users when an array of IDs were stored as the meta value.
Does this close any currently open issues?
closes #162
Any other comments?
When saving specific users in a user field:
BEFORE
Querying would return all publicly queryable users
AFTER
Querying returns just the selected users