fix: acf fields not resolving with preview #156
Conversation
chore: prep for launch on the .org repo
…gistered to the Schema - Use the registered field names and keys to determine wether or not to resolve the field from the post itself (if revision meta is supported) or the parent (if it's not).
|
@jasonbahl Thanks for looking into it. Unfortunately I still can't preview acf fields. This time, however, the query doesn't retrieve published data anymore, just null.
Just as a disclaimer: I'm not using any other plugin but WPGQL, ACF PRO and WPGQL-ACF with the changes from this PR. Default theme is twenty-twenty-four with a filter to remove guttenberg block editor. |
|
When you click preview are you right clicking to open in a new tab? If so that doesn't generate the preview data |
|
Wow... I really didn't know that. It worked!! Honestly I don't know why I did't left-clicked it before ;) Thanks immensely for that. |
|
Ya it's weird. But if you right click and open in a new tab it doesn't generate the nonce and so preview data isn't stored properly. I wonder if I can detect this somehow and output a debug message of some sort. 🤔 |
|
Yeah that would definitely be helpful for others! |
There was a problem hiding this comment.
I was able to pull this down to test.
I observed this working properly when the classic editor is active. When using the default block editor (Gutenberg), previews are not working as already called out in this PR. The additional debug notice was very helpful 🙌🏻
What does this implement/fix? Explain your changes.
This migrates some code from the previous version of WPGraphQL for ACF that got missed during the re-architecture.
Does this close any currently open issues?
closes #154
Any other comments?
Because of the missing code that wasn't ported over during the re-architecture of the plugin, querying fields on posts while using
asPreview: truewere always returning null.Now, querying a preview will return the un-published revision data:
Published Post
The published post shows the latest values that were published.
Preview of the Post
If you click "preview" when editing a post (not Update or Publish), then query for it in WPGraphQL, you will see the un-published values, stored on the "revision" post.
NOTE: The WordPress Block Editor (aka Gutenberg) has a bug that prevents Meta from being saved while using the block editor. This means that using ACF Field Groups as meta boxes on posts that also use the Block Editor beans the underlying data will not be stored on the preview and therefore cannot be resolved properly.
Posts using the Block Editor will resolve the values from the parent (published) post instead when queried as a preview.
We have added a
graphql_debugmessage to indicate this active Gutenberg issue: