Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update phpcs to match core wpgraphql #146

Merged
merged 13 commits into from
Dec 28, 2023

Conversation

jasonbahl
Copy link
Contributor

What does this implement/fix? Explain your changes.

This updates the phpcs.xml.dist file to be in line with core WPGraphQL latest standards, including updating WordPress VIP standards to latest version.

This then updates Docblocks, etc to pass phpcs checks.

Does this close any currently open issues?

closes #119

@jasonbahl jasonbahl added scope: build scripts Automating task runners and compilation processes type: chore Maintenance tasks, refactoring, and other non-functional changes labels Dec 20, 2023
@jasonbahl jasonbahl self-assigned this Dec 20, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7f869a91b4b6ffea1456d51f7e68cd4804c62a36-PR-146

  • 147 of 232 (63.36%) changed or added relevant lines in 41 files are covered.
  • 8 unchanged lines in 7 files lost coverage.
  • Overall coverage remained the same at 62.369%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/FieldType/CloneField.php 0 2 0.0%
src/FieldType/FlexibleContent.php 4 6 66.67%
src/ThirdParty/AcfExtended/FieldType/AcfeMenus.php 1 3 33.33%
src/Utils.php 13 15 86.67%
src/WPGraphQLAcf.php 0 4 0.0%
src/FieldType/Relationship.php 12 17 70.59%
src/Registry.php 37 43 86.05%
src/Admin/OptionsPageRegistration.php 0 7 0.0%
src/Admin/PostTypeRegistration.php 0 9 0.0%
src/Admin/TaxonomyRegistration.php 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/Admin/OptionsPageRegistration.php 1 0.0%
src/Admin/PostTypeRegistration.php 1 0.0%
src/Admin/Settings.php 1 0.0%
src/Admin/TaxonomyRegistration.php 1 0.0%
src/Registry.php 1 88.05%
src/ThirdParty/WPGraphQLSmartCache/WPGraphQLSmartCache.php 1 0.0%
src/FieldType/FlexibleContent.php 2 58.33%
Totals Coverage Status
Change from base Build 3891ea36305807a743eb6a681445f8651fc87544: 0.0%
Covered Lines: 2017
Relevant Lines: 3234

💛 - Coveralls

@jasonbahl jasonbahl merged commit 0eb0db5 into develop Dec 28, 2023
@jasonbahl jasonbahl mentioned this pull request Jan 23, 2024
@jasonbahl jasonbahl deleted the chore/update-phpcs-to-match-core-wpgraphql branch January 24, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: build scripts Automating task runners and compilation processes type: chore Maintenance tasks, refactoring, and other non-functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce WordPress VIP coding standards and fixes for existing errors #1535
2 participants