fix: options page with custom post_id not resolving properly #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se fallback to "options" as the default
- update tests (one still failing)
Pull Request Test Coverage Report for Build 502deaa9b0f5788d037f3d05b36e423a517930c8-PR-132
💛 - Coveralls |
jasonbahl
deleted the
fix/128-options-page-with-custom-post_id-not-resolving
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug where ACF Options Pages that are registered with a custom post_id were not resolving.
Does this close any currently open issues?
closes #128
Any relevant logs, error output, GraphiQL screenshots, etc?
Before:
After: