Skip to content

Conversation

@jasonbahl
Copy link
Contributor

What does this implement/fix? Explain your changes.

Adds new filters to the AcfGraphQLFieldType class to help 3rd parties override default behaviors of mapping ACF Field Types to the Schema.

Does this close any currently open issues?

related: #104

Any other comments?

see: #104 (comment)

… specific types of ACF Fields to return a different GraphQL Type based on certain config settings
@jasonbahl jasonbahl self-assigned this Nov 6, 2023
@jasonbahl jasonbahl changed the title Feat/add pre filter for resolve type feat: add pre filter for resolve type Nov 6, 2023
@jasonbahl jasonbahl merged commit 91e24e8 into main Nov 6, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7ef2d9015c961c5855406ba9b98f984fa32f690e-PR-114

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 8 of 11 (72.73%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 62.36%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/AcfGraphQLFieldType.php 8 11 72.73%
Totals Coverage Status
Change from base Build 31c56c6faf613c623532513491a458bcf6006607: 0.1%
Covered Lines: 2008
Relevant Lines: 3220

💛 - Coveralls

@jasonbahl jasonbahl deleted the feat/add-pre-filter-for-resolve-type branch January 24, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants