fix: #110 field groups on page templates not resolving #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…template resolver so ACF can properly resolve fields on the template object using the passed down "node" as the object to resolve fields from.
Pull Request Test Coverage Report for Build 6bcfbc457c95454ee5e905f1c148906fda4125a8-PR-112
💛 - Coveralls |
jasonbahl
deleted the
fix/#110-field-groups-on-page-templates-not-resolving
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This fixes a bug with ACF Field Groups assigned to a Page Template not resolving correctly.
Does this close any currently open issues?
closes #110
Any relevant logs, error output, GraphiQL screenshots, etc?
Before
The Field Group is queryable on the template, but the fields return
nullAfter
The Field Group is queryable on the template, and the fields return expected values
Any other comments?
The previous version of the plugin included this filter (see: https://github.com/wp-graphql/wp-graphql-acf/blob/develop/src/class-acf.php#L132-L144), but it wasn't properly ported over.