fix: oembed field type returns embed instead of URL entered to the field #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update tests to reflect the oembed response
jasonbahl
added
the
compat: breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This updates the oEmbed field to return the results of
wp_oembed_get()instead of returning the raw URL that was input to the field.Does this close any currently open issues?
closes #106
Any relevant logs, error output, GraphiQL screenshots, etc?
Before:
After:
Any other comments?
This is probably considered a breaking change to users that were previously getting the raw URL in response and doing something on the client with the url (i.e. fetching the oembed from the source, etc)
If needed, for users negatively impacted by this change, the
graphql_resolve_fieldfilter can be used to override the resolver for the field(s) to return the previous resolver logic.