Skip to content

oEmbed field type returns url, not embed #106

@jasonbahl

Description

@jasonbahl

Description

As a developer querying for a field of the oEmbed type, I expect to get the embed HTML returned so that I can use it in my client application.

Instead, the field is returning the url that was input.

Steps to reproduce

  1. Create an ACF Field Group that is set to show in GraphQL
  2. Add a field of the "oembed" type
  3. Edit content that has the field group, and enter an oembed friendly URL, such as a tweet or a youtube video
  4. Query for the field in GraphQL
  5. Expect: embed HTML

I would expect an HTML payload that could be used by the client application to render the embed:

CleanShot 2023-10-31 at 08 54 32

  1. Actual: the url that was entered

With the URL being returned, this means the client application is responsible for making the oAuth requests to get the oAuth response and determine the proper markup to apply. WordPress already does this, so we should let the server handle this and return an already cached/formatted embed.

CleanShot 2023-10-31 at 08 58 24

PHP or JSON export of the ACF Field Group(s)

No response

Additional context

No response

WPGraphQL Version

1.17.0

WPGraphQL For ACF Version

latest beta

ACF (Advanced Custom Fields) Version. Free or Pro?

latest pro

WordPress Version

6.3

PHP Version

8.1

Additional enviornment details

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have disabled ALL plugins except for WPGraphQL, WPGraphQL For ACF, ACF, etc.

  • Yes
  • My issue is with compatibility with a specific WordPress plugin, and I have listed all my installed plugins (and version info) above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions