Handle errors when editing queries in admin editor #244
Conversation
markkelnar
changed the title
jasonbahl
left a comment
jasonbahl
left a comment
There was a problem hiding this comment.
@markkelnar it seems like maybe the hook ordering still needs some work.
I'm able to add an invalid document and click "Publish" and I see the following:
The post is published and WordPress responds with a confirmation that it was published, but we also respond with an error about it being invalid, and the status is then set back to draft.
The expectation is that WordPress should not publish this post at all if it doesn't meet the validation criteria to be published.
My hunch is that some logic needs to be applied in some different hooks that execute earlier in the post save lifecylce.
|
I am not able to recreate an invalid query string being published. Do you have steps to recreate? I do see the 'Post Published' message. That is default WP behavior. I can track that down to see if I can clobber that message. |
|
@markkelnar steps to reproduce:
What appears to be happening is that the validation is happening too late. Post is published, we catch some validation then reset to draft. What I would expect is the post to not be published in the first place. If I'm not mistaken, ACF has some functionality that adds validation for things like required fields, preventing posts from being published if certain fields aren't filled in. Perhaps we can take some ideas from how they're handling things? |
|
When I use ACF to add a required field to the graphql_document post type, and click "publish" without filling in the field, I get an error and I do not see the "Post Pubished" message nor is the "published" date updated:
|
|
Thanks @jasonbahl for the example test. Acf does that validation using WP admin-ajax request and on error, displays the error you see and prevents the form submission for the edited post. That might be more work than we want to do right now. I am going to test redirecting to the edit page for the post on error before the save_post action is invoked. |
jasonbahl
left a comment
jasonbahl
left a comment
There was a problem hiding this comment.
I left a suggested change as the User Experience of clicking publish on an invalid document still appeared to publish the post even though it wasn't.
I also caught another bug.
When trashing a post of the graphql_document post type, if the document (post_content) is invalid, the error shows on the list posts screen after trashing:
I believe the validation is reaching further than it should, perhaps? I don't think we need to validate the document (post_content) when trashing/deleting a document.
|
And similar behavior with the error message from validating the content when restoring the document from the trash. Adding tests for that too. |
Co-authored-by: Jason Bahl <[email protected]>
2 participants
When editing saved persisted queries in WP admin editor, do not allow invalid queries to be published. But allow invalid queries to be saved as drafts.
closes #243