ci: add phpstan #236
Merged
ci: add phpstan #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markkelnar
commented
Jul 25, 2023
| $key, | ||
| is_array( $data ) ? $data : $data->toArray(), | ||
| $this->group_name, | ||
| // phpcs:ignore WordPressVIPMinimum.Performance.LowExpiryCacheTime.CacheTimeUndetermined |
Contributor
Author
There was a problem hiding this comment.
I'm sure there are ways to satisfy phpcs on this $expire paramter. Or just ignore the warning and move on.
jasonbahl
approved these changes
Jul 27, 2023
Collaborator
jasonbahl
left a comment
jasonbahl
left a comment
There was a problem hiding this comment.
@markkelnar sweet!
I confirmed this is working by pulling the repo locally, running composer install, then running composer phpstan.
I was able to "break" it by going to Results.php and adding a call to a non-existing method: $this->test() and I saw the following output:
Now we can start working toward higher levels!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PHP static analyzer to run in github workflow action.
closes #232