ci: tests failing after wpgraphql v1.14.5 release #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…events - update setUp to use $this->author->ID instead of $this->author - adjust test assertions
…tion" in the test suite - remove CacheInvalidationTest.php (tests moved to core WPGraphQL) - fix missing query in TermCacheInvalidationTest.php
…solving the related issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to get the automated test suites working again after they began failing with the WPGraphQL v1.14.5 release where nested
list:$typerelated: wp-graphql/wp-graphql#2861
Notes:
phpcs.xml.dist: I added a rule here as I wasn't able to succesfully runcomposer run phpcswithout it, see referenced Github linksWPGraphQLSmartCacheTestCaseWithSeedDataAndPopulatedCaches.php:getQuery()function and got rid of a lot of functions such asgetSinglePostByDatabaseIdQuery(), as the ergonomics were not ideal. ThegetQueries()has the queries and the assertions, and the readability of having them together vs abstracted intoget***Query()functions is much better now than before.wpunit/CacheInvalidationTest.php: I moved these tests into core WPGraphQLPostCacheInvalidationTest.php: I modified some assertions to work against how the code is written today. Some assertions are still not in an "ideal" state, but I wrote Track and Purge Connections #233 to follow up and hopefully get to a middle ground on some of the cache tracking/purging