fix: disable cache maps when "Use Object Cache" is disabled #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as 1.14.5 had some changes that caused tests to break) - added Settings::cache_maps_enabled() to be able to check if cache maps are enabled. Default is the same as "caching_enabled()" but can be filtered to be different (i.e. plugins that don't want to use "local" cache, but do want to track the mapping) - Prevent maps from being built/stored if cache_maps are not enabled - add filter to tests to enable cache maps (tests currently rely on the maps)
… for the 1.14.5 test
markkelnar
reviewed
Jul 14, 2023
markkelnar
reviewed
Jul 14, 2023
markkelnar
reviewed
Jul 14, 2023
markkelnar
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings::cache_maps_enabled()to be able to check if cache maps are enabled. Default is the same as "caching_enabled()" but can be filtered to be different (i.e. plugins that don't want to use "local" cache, but do want to track the mapping)closes #229