Skip to content

fix: mutations shouldn't be cached #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markkelnar merged 2 commits into from
Jul 26, 2023
Merged

fix: mutations shouldn't be cached #197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
678258f
- namespace can_load_plugin
jasonbahl Feb 21, 2023
f4ec3a0
- remove prefix from function, file is already namespaced
jasonbahl Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 77 additions & 0 deletions tests/functional/MutationsCest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
<?php

class MutationsCest {

public $post_id;

public function _before( FunctionalTester $I ) {
$this->post_id = $I->havePostInDatabase( [ 'post_title' => 'test post' ] );
}

public function mutationShouldNotBeCachedTest( FunctionalTester $I ) {

$I->wantTo( 'Execute a mutation without it being cached' );

$I->haveOptionInDatabase( 'graphql_cache_section', [ 'cache_toggle' => 'on' ] );

$query = '
mutation CreateComment($input: CreateCommentInput!) {
createComment(input: $input) {
clientMutationId
}
}
';

$clientMutationId = uniqid( 'test', true );

$variables = [
'input' => [
'clientMutationId' => $clientMutationId,
'commentOn' => $this->post_id,
'author' => 'test author',
],
];

$I->sendPost( 'graphql', [
'query' => $query,
'variables' => $variables
] );

$I->seeResponseContainsJson([
'data' => [
'createComment' => [
'clientMutationId' => $clientMutationId,
],
],
]);

$cache_response = $I->grabDataFromResponseByJsonPath( '$.extensions.graphqlSmartCache.graphqlObjectCache' );

codecept_debug($cache_response[0]);

$I->assertEmpty( $cache_response[0] );

$I->sendPost( 'graphql', [
'query' => $query,
'variables' => $variables,
] );

$I->seeResponseContainsJson([
'data' => [
'createComment' => [
'clientMutationId' => $clientMutationId,
],
],
]);

// this fails because there is a message
// output when the response has been served from the cache.
// If this is empty, then the response was _not_ served by the cache.
$cache_response = $I->grabDataFromResponseByJsonPath( '$.extensions.graphqlSmartCache.graphqlObjectCache' );


$I->assertEmpty( $cache_response[0] );

}

}